-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io/kubernetes to 1.15.0 #4719
Bump k8s.io/kubernetes to 1.15.0 #4719
Conversation
Can one of the admins verify this patch? |
A storage-provisioner dependency breaks if we bump k8s. https://github.com/r2d4/external-storage/blob/master/lib/controller/controller.go#L46 |
I am so excited for this PR ! |
Do we need the r2d4/external-storage fork any more? It isn't maintained, so if we can, it would be nice to switch to the upstream: https://github.com/kubernetes-incubator/external-storage |
@tstromberg Yup, we gonna switch. The I'm just looking the 18 commits that were done in this repo if maybe one of them we should try to move upstream. |
Excellent. If nothing jumps out, I'd just switch implementations and see if the integration tests pass. If the feature it provided really was important, it would have test coverage =) /cc @r2d4 in case he has any background to add here. |
/retest this please |
Any luck with dropping the dependency on the r2d4 fork? |
Related: #3628 |
e02b9e9
to
edb0ffa
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
edb0ffa
to
60242e5
Compare
60242e5
to
3ec9b1e
Compare
seems to be an api change
|
@minikube-bot Ok to test |
@medyagh can you trigger minikube integration tests for this PR? pls |
@minikube-bot OK to test |
Looks great ! thank you for doing this ! |
fix for #4656
still trying to figure out a couple of things here.