Remove dependecy on k8s.io/kubernetes in go mod #4656
Labels
area/dependency
Issues or PRs related to dependency changes
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
While I was trying to bump up the dependecy in go mod for k8s.io/kubernetes 1.11.3
I noticed we our go mod fails because we are importing the whole kubernetes. and I could not add a new depedency on kubectl subpackage.
Thanks to the help on golang issues, (golang/go#32864) I found out the root cause is Kubernetes is is not meant to be imported as a go module See comment golang/go#32776 (comment) . we need to import only sub-packages kuberentes and delete k8s.io/kubernetes in the the go.mod
it is a good opportunity to upgrade to 1.15.0 ( there is a few breaking api changes for apimachinary that watch.Until needs to be changed to use api machinary wait package.
if I have time I will do this, but if someone wants to take this, I would be happy to review the PR.
The text was updated successfully, but these errors were encountered: