Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if hyperkit version is old #4691

Merged
merged 5 commits into from
Jul 22, 2019
Merged

Warn if hyperkit version is old #4691

merged 5 commits into from
Jul 22, 2019

Conversation

josedonizetti
Copy link
Member

Fix for #4658

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

medyagh
medyagh requested changes Jul 7, 2019
View reviewed changes
cmd/minikube/cmd/start.go Show resolved Hide resolved
@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2019
@josedonizetti josedonizetti force-pushed the warn-if-hyperkit-version-is-old branch from 3d9b19b to 0685632 Compare July 10, 2019 22:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josedonizetti
Copy link
Member Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

LGTM, but needs rebase.

@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@RA489
Copy link

RA489 commented Jul 18, 2019

@josedonizetti please resolve the conflicts rest LGTM.

@josedonizetti josedonizetti force-pushed the warn-if-hyperkit-version-is-old branch from 1e8fc78 to 91e2d0a Compare July 18, 2019 13:52
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 18, 2019
@josedonizetti josedonizetti force-pushed the warn-if-hyperkit-version-is-old branch from 91e2d0a to 95c2e7c Compare July 22, 2019 20:20
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2019
@sharifelgamal sharifelgamal merged commit 6a5fbba into kubernetes:master Jul 22, 2019
@josedonizetti josedonizetti deleted the warn-if-hyperkit-version-is-old branch July 22, 2019 22:38
medyagh added a commit that referenced this pull request Jul 22, 2019
@medyagh
Revert "Warn if hyperkit version is old (#4691)"
8036138 
This reverts commit 6a5fbba.
@medyagh medyagh mentioned this pull request Jul 22, 2019
Closed
@tstromberg tstromberg mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@tstromberg tstromberg tstromberg approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@josedonizetti @minikube-bot @sharifelgamal @k8s-ci-robot @tstromberg @RA489 @medyagh