WIP: Add warn about old driver version (hyperkit, kvm) #4681

RA489 · 2019-07-04T08:12:21Z

Add warn about old driver version (hyperkit, kvm)
fixes #4658

k8s-ci-robot · 2019-07-04T08:12:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RA489]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

josedonizetti · 2019-07-04T12:09:38Z

pkg/minikube/problem/err_map.go

+	"OLD_HYPERKIT_VERSION": {
+		Regexp: re(`Too old hyperkit version found`),
+		Advice: "too old hyperkit version. Jump forward to new valid hyperkit version as a workaround.",
+		Issues: []int{4658},


Add URL to documentation on how to upgrade.

Add this doc: https://github.com/kubernetes/minikube/blob/master/docs/drivers.md

josedonizetti · 2019-07-04T12:09:44Z

pkg/minikube/problem/err_map.go

@@ -119,6 +124,11 @@ var vmProblems = map[string]match{
 		URL:    "http://mikko.repolainen.fi/documents/virtualization-with-kvm",
 		Issues: []int{2991},
 	},
+	"OLD_KVM_VERSION": {
+		Regexp: re(`Too old KVM version found`),
+		Advice: "too old KVM version. Jump forward to new valid KVM version as a workaround.",


Add URL to documentation on how to upgrade.

@josedonizetti done!

josedonizetti · 2019-07-04T12:13:01Z

@RA489 I added two comments, but I don't understand how this fixes the issue. For me, the problem package would display a message based on an existing error that matches the regex. But I never saw those drivers message before Too old KVM/Hyperkit version found if they already exist is great and I can close the PR I opened to check it #4676. Thanks :)

tstromberg · 2019-07-11T18:43:21Z

pkg/minikube/problem/err_map.go

@@ -36,6 +36,11 @@ var vmProblems = map[string]match{
 		URL:    "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-driver",
 		Issues: []int{1926, 4206},
 	},
+	"OLD_HYPERKIT_VERSION": {
+		Regexp: re(`Too old hyperkit version found`),


Make sure this regexp matches the exit error thrown at head - #4676 introduced some changes.

josedonizetti

@RA489 I still fail to see which minikube messages are those regexp matching. If you can show in the code, or maybe the output of minikube would help a lot clarify it. Thank you!

Because considering the latest changes to minikube, I think those regexes should match the message here: https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/start.go#L945

josedonizetti · 2019-07-30T12:03:43Z

pkg/minikube/problem/err_map.go

+	"OLD_HYPERKIT_VERSION": {
+		Regexp: re(`Add warn about old driver version (hyperkit, kvm)`),
+		Advice: "Too old hyperkit version. Jump forward to new valid hyperkit version as a workaround.",
+		URL:	"https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"


Suggested change

URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"

URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-upgrade",

There's a specific link for hyperkit upgrade. Also missing a comma at the end.

josedonizetti · 2019-07-30T12:04:39Z

pkg/minikube/problem/err_map.go

+	"OLD_KVM_VERSION": {
+		Regexp: re(`Too old KVM version found`),
+		Advice: "too old KVM version. Jump forward to new valid KVM version as a workaround.",
+		URL:	"https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"


Suggested change

URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"

URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm2-upgrade",

There's a specific link for kvm upgrade. Also missing a comma at the end.

josedonizetti · 2019-07-30T12:08:21Z

pkg/minikube/problem/err_map.go

@@ -36,6 +36,12 @@ var vmProblems = map[string]match{
 		URL:    "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-driver",
 		Issues: []int{1926, 4206},
 	},
+	"OLD_HYPERKIT_VERSION": {
+		Regexp: re(`Add warn about old driver version (hyperkit, kvm)`),


Which message is this regexp matching? Do you have an example of where this message is displayed to the user?

josedonizetti · 2019-07-30T12:08:35Z

pkg/minikube/problem/err_map.go

@@ -119,6 +125,12 @@ var vmProblems = map[string]match{
 		URL:    "http://mikko.repolainen.fi/documents/virtualization-with-kvm",
 		Issues: []int{2991},
 	},
+	"OLD_KVM_VERSION": {
+		Regexp: re(`Too old KVM version found`),


Which message is this regexp matching? Do you have an example of where this message is displayed to the user?

tstromberg · 2019-09-05T18:19:23Z

Closing in preference to #4691

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2019

k8s-ci-robot requested review from afbjorklund and balopat July 4, 2019 08:12

josedonizetti reviewed Jul 4, 2019

View reviewed changes

josedonizetti mentioned this pull request Jul 4, 2019

Add warn if kvm driver version is old #4676

Merged

tstromberg changed the title ~~Add warn about old driver version (hyperkit, kvm)~~ WIP: Add warn about old driver version (hyperkit, kvm) Jul 11, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2019

RA489 force-pushed the sm branch from 0ea8e5c to 3e478f8 Compare July 16, 2019 01:26

tstromberg suggested changes Jul 29, 2019

View reviewed changes

Add warn about old driver version (hyperkit, kvm)

f135440

RA489 force-pushed the sm branch from 3e478f8 to f135440 Compare July 30, 2019 02:34

josedonizetti suggested changes Jul 30, 2019

View reviewed changes

tstromberg closed this Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Add warn about old driver version (hyperkit, kvm) #4681

WIP: Add warn about old driver version (hyperkit, kvm) #4681

RA489 commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

josedonizetti Jul 4, 2019

tstromberg Jul 11, 2019

RA489 Jul 16, 2019

josedonizetti Jul 4, 2019

RA489 Jul 16, 2019

josedonizetti commented Jul 4, 2019 •

edited

Loading

tstromberg Jul 11, 2019 •

edited

Loading

RA489 Jul 30, 2019

josedonizetti left a comment •

edited

Loading

josedonizetti Jul 30, 2019

josedonizetti Jul 30, 2019

josedonizetti Jul 30, 2019 •

edited

Loading

josedonizetti Jul 30, 2019 •

edited

Loading

tstromberg commented Sep 5, 2019

	URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"
	URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-upgrade",

WIP: Add warn about old driver version (hyperkit, kvm) #4681

WIP: Add warn about old driver version (hyperkit, kvm) #4681

Conversation

RA489 commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josedonizetti commented Jul 4, 2019 • edited Loading

tstromberg Jul 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josedonizetti left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josedonizetti Jul 30, 2019 • edited Loading

Choose a reason for hiding this comment

josedonizetti Jul 30, 2019 • edited Loading

Choose a reason for hiding this comment

tstromberg commented Sep 5, 2019

josedonizetti commented Jul 4, 2019 •

edited

Loading

tstromberg Jul 11, 2019 •

edited

Loading

josedonizetti left a comment •

edited

Loading

josedonizetti Jul 30, 2019 •

edited

Loading

josedonizetti Jul 30, 2019 •

edited

Loading