-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to custom qemu uri on kvm2 driver #4401
Add support to custom qemu uri on kvm2 driver #4401
Conversation
Hi @josedonizetti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor nit.
@minikube-bot OK to test |
/ok-to-test |
c4ed6c0
to
45b1864
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest this please |
Approving, but the PR does need a rebase and passing tests before merging. |
45b1864
to
107a7bc
Compare
107a7bc
to
3a82099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. would be great to add documentation for it !
@josedonizetti Please squash the commits to one rest LGTM. |
@medyagh Do you think we can merge this without the documentation? I was looking and we currently don't have documentation to any of the kvm flags. I was wondering if I could create a separate PR that document all of them at once? WDYT? Also, where would be good to document such flags? |
@medyagh ping |
Yes a separate PR would work, thank you for this great PR :) @josedonizetti I was wondering if we could have a tutotiral showing KVM on google cloud and minikube ? |
Add an undocumented option introduced by kubernetes#4401
Fix #4069