Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to custom qemu uri on kvm2 driver #4401

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

josedonizetti
Copy link
Member

Fix #4069

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor nit.

pkg/minikube/config/types.go Outdated Show resolved Hide resolved
@RA489
Copy link

RA489 commented Jun 2, 2019

@minikube-bot OK to test

@afbjorklund
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jun 15, 2019

/retest this please

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2019
@tstromberg
Copy link
Contributor

Approving, but the PR does need a rebase and passing tests before merging.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2019
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. would be great to add documentation for it !

@RA489
Copy link

RA489 commented Jun 26, 2019

@josedonizetti Please squash the commits to one rest LGTM.

@josedonizetti
Copy link
Member Author

josedonizetti commented Jun 26, 2019

@medyagh Do you think we can merge this without the documentation? I was looking and we currently don't have documentation to any of the kvm flags. I was wondering if I could create a separate PR that document all of them at once? WDYT?

Also, where would be good to document such flags? docs/drivers.md?

@josedonizetti
Copy link
Member Author

@medyagh ping

@medyagh
Copy link
Member

medyagh commented Jun 28, 2019

@medyagh Do you think we can merge this without the documentation? I was looking and we currently don't have documentation to any of the kvm flags. I was wondering if I could create a separate PR that document all of them at once? WDYT?

Also, where would be good to document such flags? docs/drivers.md?

Yes a separate PR would work, thank you for this great PR :)

@josedonizetti I was wondering if we could have a tutotiral showing KVM on google cloud and minikube ?

@medyagh medyagh merged commit 9dfe660 into kubernetes:master Jun 28, 2019
@josedonizetti josedonizetti deleted the add-kvm-qemu-uri-flag branch June 28, 2019 21:13
drc0 added a commit to drc0/minikube that referenced this pull request May 19, 2020
Add an undocumented option introduced by kubernetes#4401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvm2: Add support for LIBVIRT_DEFAULT_URI
7 participants