Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for all vm drivers #4633

Closed
medyagh opened this issue Jun 28, 2019 · 4 comments
Closed

Add integration tests for all vm drivers #4633

medyagh opened this issue Jun 28, 2019 · 4 comments
Labels
area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/process Process oriented issues, like setting up CI lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Jun 28, 2019

It would be nice to have integration tests that only tests the functionality of VM drivers. in different scenarios.

( just an empty VM without installing kubelet or anyhting ) to test following

  • start, stop, delete
  • start, start, delete
  • start, delete, start
  • ...

We could make integration tests for VM drivers to be triggered only if the driver package been changed.
@medyagh medyagh changed the title Integration tests for all vm drivers Add integration tests for all vm drivers Jun 28, 2019
@medyagh medyagh added area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 28, 2019
@josedonizetti
Copy link
Member

josedonizetti commented Jun 28, 2019 •
edited
Loading

I was considering adding tests to the kvm driver using the test driver.

The test driver is a dummy hypervisor for test purposes. The URIs supported are:

test:///default connects to a default set of host definitions built into the driver.

This would be pretty simple once we merge: #4401

@tstromberg tstromberg added kind/process Process oriented issues, like setting up CI priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Sep 20, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 18, 2020
@medyagh
Copy link
Member Author

medyagh commented Feb 12, 2020 •
edited
Loading

this doesn't seem to be needed anymore with all the testing we do with minikube itself.

@medyagh medyagh closed this as completed Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/process Process oriented issues, like setting up CI lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@josedonizetti @tstromberg @medyagh @k8s-ci-robot @fejta-bot