Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default output of 'minikube start' consume fewer lines in the terminal #4197

Merged
merged 3 commits into from
May 7, 2019
Merged

Make default output of 'minikube start' consume fewer lines in the terminal #4197

merged 3 commits into from
May 7, 2019

Conversation

dpandhi-git
Copy link
Contributor

This PR fixes #4187

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @dpandhi-git. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dpandhi-git
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@sharifelgamal
Copy link
Collaborator

The Travis failures are just simple gofmt issues.

@tstromberg
Copy link
Contributor

OSX-Hyperkit test failure seems to be an unrelated flake. CLA issue still needs to be addressed though. It seems like the first commits don't have their name/address matched to your GitHub user:

https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

tstromberg
tstromberg suggested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! To close the issue, I think this PR should also change the following call in kubeadm.go to glog.Infof:

console.OutStyle("permissions", "Configuring cluster permissions ...")

I think we can also safely remove the console.Out calls in start.go:validateCluster()

Thanks for taking this on!

cmd/minikube/cmd/start.go Outdated
}

func showKubectlConnectInfo(kubeconfig *pkgutil.KubeConfigSetup) {
if kubeconfig.KeepContext {
console.OutStyle("kubectl", "To connect to this cluster, use: kubectl --context=%s", kubeconfig.ClusterName)
} else {
console.OutStyle("kubectl", "kubectl is now configured to use %q", cfg.GetMachineName())
console.OutStyle("kubectl", "Done! kubectl is now configured to use %q", cfg.GetMachineName())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the "ready" style.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2019
@dpandhi-git
Copy link
Contributor Author

Can anyone help with latest travis build failed?

Also I might need help for cla/linux foundation error. I tried the steps mentioned in details but it does not seem to work. My git account has two email ids one primary is E1 and other is E2 . E2 one is used when login with linux foundation to sign the CLA will that cause any issue? was checking people have faced similar issue cncf/foundation#26 (comment)

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

The broken Travis build was my fault - and should not happen again.

It appears that this commit is not associated to your GitHub e-mail address:

https://github.com/kubernetes/minikube/commit/ee4e514282811a95dcc4c6bf31f3f4c868aa1890.patch

The e-mail address for this commit is dpandhi@Deepikas-MacBook-Pro-2.local

https://gist.github.com/trey/9588090 explains how to go back and fix the e-mail address for an older commit in a PR. Hope this helps! I can't wait for this change to land =)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2019
@dpandhi-git
Copy link
Contributor Author

The broken Travis build was my fault - and should not happen again.

It appears that this commit is not associated to your GitHub e-mail address:

https://github.com/kubernetes/minikube/commit/ee4e514282811a95dcc4c6bf31f3f4c868aa1890.patch

The e-mail address for this commit is dpandhi@Deepikas-MacBook-Pro-2.local

https://gist.github.com/trey/9588090 explains how to go back and fix the e-mail address for an older commit in a PR. Hope this helps! I can't wait for this change to land =)

Thanks for info on git. Passed CLA test. Thanks for making my first contribution to K8s successful

@tstromberg tstromberg changed the title Changed minikube start output as per #4187 Make default output of 'minikube start' consume fewer lines in the terminal May 7, 2019
@tstromberg tstromberg merged commit 756cd0f into kubernetes:master May 7, 2019
@tstromberg
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shorten minikube start output
5 participants
@dpandhi-git @k8s-ci-robot @minikube-bot @tstromberg @sharifelgamal