Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten minikube start output #4187

Closed
tstromberg opened this issue May 1, 2019 · 3 comments · Fixed by #4197
Closed

Shorten minikube start output #4187

tstromberg opened this issue May 1, 2019 · 3 comments · Fixed by #4197
Assignees
@tstromberg
Labels
kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.1.0

Comments

@tstromberg
Copy link
Contributor

tstromberg commented May 1, 2019 •
edited
Loading

minikube start has gotten to be overly verbose in a default configuration: 15 lines of output, or 1 message for every 10 seconds of runtime.

I feel like we should be able to get down to roughly half this total (~8 lines) without degrading the user experience substantially. Here is what head currently looks like:

😄  minikube v1.0.1 on linux (amd64)
🤹  Downloading Kubernetes v1.14.1 images in the background ...
🔥  Creating kvm2 VM (CPUs=2, Memory=2048MB, Disk=20000MB) ...
📶  "minikube" IP address is 192.168.39.240
🐳  Configuring Docker as the container runtime ...
🐳  Version of container runtime is 18.06.3-ce
⌛  Waiting for image downloads to complete ...
✨  Preparing Kubernetes environment ...
🚜  Pulling images required by Kubernetes v1.14.1 ...
🚀  Launching Kubernetes v1.14.1 using kubeadm ... 
⌛  Waiting for pods: apiserver proxy etcd scheduler controller dns
🔑  Configuring cluster permissions ...
🤔  Verifying component health .....
💗  kubectl is now configured to use "minikube"
🏄  Done! Thank you for using minikube!

Here is a strawman proposal, at 7 lines:

😄 minikube v1.1.0 on CentOS Linux (amd64)
🔥 Creating kvm2 VM (2 CPUs, 2GB RAM, 20GB disk)
🐳 Configuring environment for Kubernetes v1.14.1 on Docker v18.03
🚜 Pulling images ...
🚀 Launching Kubernetes ... 
⌛ Waiting for: apiserver proxy etcd scheduler controller dns
🏄 Done! kubectl is now configured to use "minikube"

This equates to 1 message every 21 seconds of runtime, which is far less spammy.
@tstromberg tstromberg changed the title Make minikube start output less verbose (less translation work!) Shorten minikube start output May 1, 2019
@tstromberg tstromberg added this to the v1.1.0 milestone May 1, 2019
@tstromberg tstromberg self-assigned this May 1, 2019
@hpandeycodeit
Copy link

@tstromberg is this open to work on?

@tstromberg
Copy link
Contributor Author

@hpandeycodeit - Yes! PR's welcome.

@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 2, 2019
@afbjorklund
Copy link
Collaborator

afbjorklund commented May 2, 2019 •
edited
Loading

Some of this ouput looks longer, like addition of distribution to the OS version ? :-)

Also, there's some rounding going on there in our default 19.5GB disk image size.
Then again I always wondered why it was "odd" like that, why not an even 20480M

Some standardization there would be good, not sure if we should go all in on gibibyte ?

dpandhi-git pushed a commit to dpandhi-git/minikube that referenced this issue May 2, 2019
Changed miikube start output as per kubernetes#4187
ee4e514
@dpandhi-git dpandhi-git mentioned this issue May 2, 2019
Merged
dpandhi-git added a commit to dpandhi-git/minikube that referenced this issue May 3, 2019
@dpandhi-git
Did go format check for travis build kubernetes#4187
8286e5a
dpandhi-git added a commit to dpandhi-git/minikube that referenced this issue May 4, 2019
@dpandhi-git
impleted review updates for kubernetes#4187
559cf0f
dpandhi-git added a commit to dpandhi-git/minikube that referenced this issue May 7, 2019
@dpandhi-git
anged email address for commit & impleted review updates for kubernet…
0f2d79d 
…es#4187
dpandhi-git added a commit to dpandhi-git/minikube that referenced this issue May 7, 2019
@dpandhi-git
Changed minikube start output as per kubernetes#4187
183322f
dpandhi-git added a commit to dpandhi-git/minikube that referenced this issue May 7, 2019
@dpandhi-git
Did go format check for travis build kubernetes#4187
498b719
dpandhi-git added a commit to dpandhi-git/minikube that referenced this issue May 7, 2019
@dpandhi-git
anged email address for commit & impleted review updates for kubernet…
c98ba69 
…es#4187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstromberg tstromberg

Labels
kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Make default output of 'minikube start' consume fewer lines in the terminal dpandhi-git/minikube
3 participants
@tstromberg @afbjorklund @hpandeycodeit