Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the low-hanging fruit on report card #3841

Merged
merged 6 commits into from
Mar 21, 2019

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Mar 10, 2019

Should fix the 99% on https://goreportcard.com/report/github.com/kubernetes/minikube:

minikube/pkg/minikube/tunnel/registry.go
Line 124: error: result of fmt.Errorf call not used (vet)
Line 161: error: result of fmt.Errorf call not used (vet)

minikube/cmd/minikube/cmd/env.go
Line 330: warning: ineffectual assignment to err (ineffassign)

minikube/pkg/gvisor/enable.go
Line 120: warning: "downlaods" is a misspelling of "downloads" (misspell)
minikube/pkg/minikube/console/style.go
Line 96: warning: "embarassed" is a misspelling of "embarrassed" (misspell)

The "gocyclo" complexitiies are left to do, as is "golint" (which even got a separate #3839).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2019
minikube/pkg/minikube/tunnel/registry.go
    Line 124: error: result of fmt.Errorf call not used (vet)
    Line 161: error: result of fmt.Errorf call not used (vet)
minikube/cmd/minikube/cmd/env.go
    Line 330: warning: ineffectual assignment to err (ineffassign)
minikube/pkg/gvisor/enable.go
    Line 120: warning: "downlaods" is a misspelling of "downloads" (misspell)
minikube/pkg/minikube/console/style.go
    Line 96: warning: "embarassed" is a misspelling of "embarrassed" (misspell)
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2019
@afbjorklund
Copy link
Collaborator Author

New score: (make reportcard)

Grade: A+ (99.6%)
Files: 2093
Issues: 68
gofmt: 100%
go_vet: 100%
golint: 97%
gocyclo: 99%
ineffassign: 100%
license: 100%
misspell: 100%

@tstromberg tstromberg merged commit f9a136a into kubernetes:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants