-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address the low-hanging fruit on report card #3841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Mar 10, 2019
k8s-ci-robot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Mar 10, 2019
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Mar 10, 2019
minikube/pkg/minikube/tunnel/registry.go Line 124: error: result of fmt.Errorf call not used (vet) Line 161: error: result of fmt.Errorf call not used (vet)
minikube/cmd/minikube/cmd/env.go Line 330: warning: ineffectual assignment to err (ineffassign)
minikube/pkg/gvisor/enable.go Line 120: warning: "downlaods" is a misspelling of "downloads" (misspell) minikube/pkg/minikube/console/style.go Line 96: warning: "embarassed" is a misspelling of "embarrassed" (misspell)
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 10, 2019
New score: (
|
tstromberg
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the 99% on https://goreportcard.com/report/github.com/kubernetes/minikube:
The "gocyclo" complexitiies are left to do, as is "golint" (which even got a separate #3839).