Go Lint Cleanup #3839
Merged
Go Lint Cleanup #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two lint warnings still remain, after the cleanup: "exported ... should have comment or be unexported" "type name will be used as foo.FooBar by other packages, and that stutters; consider calling this Bar"
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
First step towards improving the current 70% rating, for lint on code: |
This was referenced Mar 10, 2019
tstromberg
approved these changes
Mar 11, 2019
Make config get/set more symmetrical, as well.
Removing the kubeconfig module is probably not a big deal, since it was already hiding under the "util" directory... But the layout of the Bootstrapper is slightly irritating, as long as it is contained in a different "kubeadm" module.
k8s-ci-robot
added
size/XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of exported things to document, apparently...