Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none UX: Reword warnings and other strings for accuracy #3680

Merged
merged 5 commits into from
Feb 15, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 15, 2019

Minor display fixes I noticed while battle-testing minikube with the none driver:

  • Remove kubectl download guidance when minikube is run without kubectl in path, as is often the case when run as root. The installation guidance provided conflicted with the offficial instructions anyways.
  • The giant none warning was no longer accurate. Linked to doc for more information.
  • Make chown command work when there is no group named $USER
  • The dashboard will now exit much earlier if kubectl is missing.
  • Log an error if the bootstrapper can't be initialized
  • Some mentions of VM should actually be cluster, particularly when used with none.

Sample output:

😄  minikube v0.33.1 on linux (amd64)
🤹  Configuring local host environment ...

⚠️  The 'none' driver provides limited isolation and may reduce system security and reliability.
⚠️  For more information, see:
👉  https://github.com/kubernetes/minikube/blob/master/docs/vmdriver-none.md

⚠️  kubectl and minikube configuration will be stored in /root
⚠️  To use kubectl or minikube commands as your own user, you may
⚠️  need to relocate them. For example, to overwrite your own settings:

    ▪ sudo mv /root/.kube /root/.minikube $HOME
    ▪ sudo chown -R $USER $HOME/.kube $HOME/.minikube

💡  This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true
💡  Tip: To create a new cluster, use 'minikube start -p <new name>' or use 'minikube delete' to delete this one.
🏃  Re-using the currently running none VM for "minikube" ...
⌛  Waiting for SSH access ...
📶  "minikube" IP address is 172.31.148.205
🐳  Configuring Docker as your container runtime ...
✨  Preparing Kubernetes environment ...
🚜  Pulling images used by Kubernetes v1.13.3 ...
🔄  Relaunching Kubernetes v1.13.3 using kubeadm ... 
⌛  Restarting kube-proxy ...

This resolves #3429 and #3263

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2019
@tstromberg tstromberg changed the title UX: Improve console output when used with the none driver Better none UX: Refactor kubectl and none driver warnings, other minor things Feb 15, 2019
@tstromberg tstromberg changed the title Better none UX: Refactor kubectl and none driver warnings, other minor things Better none: Refactor kubectl and none driver warnings, other minor things Feb 15, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg tstromberg changed the title Better none: Refactor kubectl and none driver warnings, other minor things none UIX: Refactor kubectl and none driver warnings, other minor strings Feb 15, 2019
@tstromberg tstromberg changed the title none UIX: Refactor kubectl and none driver warnings, other minor strings none UX: Reword warnings and other strings for accuracy Feb 15, 2019
@tstromberg tstromberg merged commit 4142c6d into kubernetes:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube start --help and the README.md should warn more prominently about --vm-driver=none
3 participants