Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete "The 'none' driver will run an insecure kubernetes apiserver" warning? #3263

Closed
ensonic opened this issue Oct 19, 2018 · 3 comments
Closed
Labels
co/none-driver help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@ensonic
Copy link
Contributor

ensonic commented Oct 19, 2018

BUG REPORT

Please provide the following details:

Environment:
minikube git HEAD

What happened:
Minikube emits this warning when using vm-driver=none
https://github.com/kubernetes/minikube/blob/ae9f4b20c7fcb7a89fc65e6eab0fb716f4d1a4ed/cmd/minikube/cmd/start.go#L341_L346

This pull request imho addressed the warning
#1694

What you expected to happen:
Not seeing the warning anymore.

If you agree I can send a follow PR to remove the warning and make the option that can be used to suppress the warning a dummy (let me know if you have a different policy for handling obsolete settings).

@tstromberg
Copy link
Contributor

I believe the intent of the warning is still legitimate, even if the specific wording is out of date. I've added a note in the documentation outlining some possible issues:

https://github.com/kubernetes/minikube/blob/master/docs/vmdriver-none.md#should-vm-drivernone-be-used-on-a-personal-development-machine-no

Perhaps we should update the error message to simply point to there?

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. co/none-driver labels Oct 30, 2018
@ensonic
Copy link
Contributor Author

ensonic commented Nov 1, 2018

Yes, please. The recent addition of the vmdriver=node docs are a great step. As it is the warning itself is not sufficient, explaining the 'why' is important for people to understand.

@tstromberg tstromberg added kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 23, 2019
@tstromberg tstromberg added this to the v1.0.0-candidate milestone Jan 23, 2019
@tstromberg tstromberg added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 24, 2019
@tstromberg
Copy link
Contributor

Fixed in v0.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/none-driver help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants