Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial documentation for --vm-driver=none #3240

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

tstromberg
Copy link
Contributor

Resolves #2575

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2018
@bhack
Copy link

bhack commented Oct 9, 2018

What it is the status of #2926?
Cause probably we can suggest a lighter solution for users that are looking for none.

@harpratap
Copy link

Please also add this - To make your locally built images run in minikube you need to tag your images with a version other than latest. Only then minikube will be able to pull those, the docker daemon is shared with minikube and your machine so no need to creating a separate repo.

@tstromberg tstromberg changed the title Add initial documentation for --vm-driver=None Add initial documentation for --vm-driver=none Oct 11, 2018
@bw2
Copy link

bw2 commented Oct 11, 2018

When talking about running "within a customized VM environment" vs. "outside of a VM", what is a VM in this context? For example, is it bad to use --vm-driver=none on vanilla linux severs (with lets say CentOS7 or Ubuntu18)?

It would be helpful to specifically define "VM" and "developer machine".

docs/vmdriver-none.md Outdated Show resolved Hide resolved
@jakefeasel
Copy link
Contributor

jakefeasel commented Oct 11, 2018

Sad as this documentation makes me, at least it does clarify the intent for this feature. Thanks.

On another note, it would be really nice if we could point people who are interested in running k8s directly on their servers to other projects which would help them accomplish that goal.

@tstromberg
Copy link
Contributor Author

Sad as this documentation makes me, at least it does clarify the intent for this feature. Thanks.

On another note, it would be really nice if we could point people who are interested in running k8s directly on their servers to other projects which would help them accomplish that goal.

You've raised a good point about a valid use case. I've updated the docs in a way which hopefully captures the conditions in which you may want to run --vm-driver outside of a VM.

@bhack
Copy link

bhack commented Oct 11, 2018

Probably there could be also some other alternatives to the insecure none like #3244

* You cannot run more than one `--vm-driver=none` instance on a single host #2781
* `--vm-driver=none` deletes other local docker images #2705
* `--vm-driver=none` fails on distro's which do not use systemd #2704
* Many `minikube` commands are not supported, such as: `dashboard`, `mount`, `ssh`, `stop` (#3127)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, please provide reference to issue

@RA489
Copy link

RA489 commented Oct 16, 2018

@tstromberg please squash the commit to one.

@tstromberg
Copy link
Contributor Author

tstromberg commented Oct 19, 2018

@tstromberg please squash the commit to one.

Done, though I also don't feel it's explicitly necessary to squash commits.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

docs/vmdriver-none.md Outdated Show resolved Hide resolved
docs/vmdriver-none.md Show resolved Hide resolved
Co-Authored-By: tstromberg <tstromberg@google.com>
@tstromberg tstromberg merged commit 3123a4e into kubernetes:master Oct 19, 2018
@tstromberg tstromberg deleted the vmdriver=None branch October 19, 2018 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants