-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial documentation for --vm-driver=none #3240
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What it is the status of #2926? |
Please also add this - To make your locally built images run in minikube you need to tag your images with a version other than |
When talking about running "within a customized VM environment" vs. "outside of a VM", what is a VM in this context? For example, is it bad to use --vm-driver=none on vanilla linux severs (with lets say CentOS7 or Ubuntu18)? It would be helpful to specifically define "VM" and "developer machine". |
Sad as this documentation makes me, at least it does clarify the intent for this feature. Thanks. On another note, it would be really nice if we could point people who are interested in running k8s directly on their servers to other projects which would help them accomplish that goal. |
You've raised a good point about a valid use case. I've updated the docs in a way which hopefully captures the conditions in which you may want to run --vm-driver outside of a VM. |
Probably there could be also some other alternatives to the insecure none like #3244 |
docs/vmdriver-none.md
Outdated
* You cannot run more than one `--vm-driver=none` instance on a single host #2781 | ||
* `--vm-driver=none` deletes other local docker images #2705 | ||
* `--vm-driver=none` fails on distro's which do not use systemd #2704 | ||
* Many `minikube` commands are not supported, such as: `dashboard`, `mount`, `ssh`, `stop` (#3127) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, please provide reference to issue
@tstromberg please squash the commit to one. |
892d72a
to
f3ba397
Compare
Done, though I also don't feel it's explicitly necessary to squash commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Co-Authored-By: tstromberg <tstromberg@google.com>
Resolves #2575