Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some more vendored k8s. #3014

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Remove some more vendored k8s. #3014

merged 1 commit into from
Jul 26, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jul 24, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 24, 2018
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 24, 2018

This should fix #2869 as well.

@dlorenc dlorenc mentioned this pull request Jul 24, 2018
@stantonxu
Copy link

@dlorenc , it seems to me that you only removed the package log under cfssl, the other packages under cfssl are still there. It still has the dependency on google/certificate-transparency-go, so we still need to update the dependency of cfssl, as it currently depends on google/certificate-transparency/go, which will make the make test still fail with golang 1.10.

@dlorenc dlorenc merged commit 232080a into kubernetes:master Jul 26, 2018
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 26, 2018

@dlorenc , it seems to me that you only removed the package log under cfssl, the other packages under cfssl are still there. It still has the dependency on google/certificate-transparency-go, so we still need to update the dependency of cfssl, as it currently depends on google/certificate-transparency/go, which will make the make test still fail with golang 1.10.

Revert View details

Yeah thanks for noticing, I'll take another look.

@dlorenc dlorenc deleted the rmmore branch July 26, 2018 15:23
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 26, 2018

@stantonxu actually can you check again? cfssl is gone in https://github.com/kubernetes/minikube/tree/master/vendor/github.com

@stantonxu
Copy link

@dlorenc yes, cfssl is gone now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants