Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.10.1 everywhere. #2777

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update to go 1.10.1 everywhere. #2777

merged 1 commit into from
Jul 26, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Apr 30, 2018

Fixes #2770

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2018
@dlorenc
Copy link
Contributor Author

dlorenc commented May 3, 2018

@minikube-bot test this please

2 similar comments
@dlorenc
Copy link
Contributor Author

dlorenc commented May 10, 2018

@minikube-bot test this please

@dlorenc
Copy link
Contributor Author

dlorenc commented May 11, 2018

@minikube-bot test this please

@dlorenc
Copy link
Contributor Author

dlorenc commented Jun 5, 2018

@minikube-bot test this please

@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 24, 2018

This should be ready to go after #3014 goes in.

@dlorenc dlorenc mentioned this pull request Jul 24, 2018
Closed
@stantonxu stantonxu mentioned this pull request Jul 24, 2018
Closed
aaron-prindle
aaron-prindle approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does the Linux build VM also have go 1.10?

@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 26, 2018

LGTM. Does the Linux build VM also have go 1.10?

yeah it's all done in docker so it should be good.

@dlorenc dlorenc merged commit 4c89d41 into kubernetes:master Jul 26, 2018
@dlorenc dlorenc deleted the go110 branch July 26, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@aaron-prindle aaron-prindle aaron-prindle approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @k8s-ci-robot @aaron-prindle @nkubala