-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VirtualBox driver uses virtio network driver #2211
Conversation
Kernel has CONFIG_VIRTIO_NET=y. Read more at https://www.virtualbox.org/manual/ch06.html
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
Any chance you can sign the CLA? |
@dlorenc yes, CLA is green now. |
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
==========================================
+ Coverage 27.73% 27.76% +0.02%
==========================================
Files 82 82
Lines 5538 5540 +2
==========================================
+ Hits 1536 1538 +2
Misses 3806 3806
Partials 196 196
Continue to review full report at Codecov.
|
@minikube-bot ok to teset |
@minikube-bot test this please |
We could avoid making this a flag and set it by default for all platforms except Windows, if we think it won't work there. We'd have to move |
Actually this looks good - it looks like any recent version of windows supports this so it should be safe. |
Kernel has CONFIG_VIRTIO_NET=y.
Read more at https://www.virtualbox.org/manual/ch06.html
Closes #2196.