Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualBox support for virtio-net network adapter #2196

Closed
ijl opened this issue Nov 14, 2017 · 2 comments
Closed

VirtualBox support for virtio-net network adapter #2196

ijl opened this issue Nov 14, 2017 · 2 comments
Labels
co/virtualbox kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ijl
Copy link
Contributor

ijl commented Nov 14, 2017

I'd like to add support for the virtualbox driver to use the virtio-net network adapter. This is to improve performance.

minikube should probably just default to virtio-net given we know we're using a Linux 2.6.25+ kernel. See the VBoxManage docs: https://www.virtualbox.org/manual/ch06.html. The default in docker machine is currently defaultHostOnlyNictype = "82540EM", which docs note supports Windows.

If changing the default isn't acceptable or it should be configurable, it seems consistent to support this usage: minikube start --vm-driver=virtualbox --virtualbox-network=virtio-net. There's an existing, similar --kvm-network flag.

@r2d4 r2d4 added co/virtualbox kind/feature Categorizes issue or PR as related to a new feature. labels Nov 16, 2017
@r2d4
Copy link
Contributor

r2d4 commented Nov 16, 2017

I think its reasonable to make it the default as long as it works across all platforms. If it doesn't work for a particular platform (windows?) then I still think its reasonable to add it as a flag.

@chancez
Copy link
Member

chancez commented Dec 6, 2017

I never even thought about this, but this is likely to be a huge improvement. Any thoughts on making it possible to specify the network adapter type via a flag or config option? Might be nice to be able to use the intel NICs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/virtualbox kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants