Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience container-runtime flag for kubeadm #2052

Merged
merged 6 commits into from
Oct 17, 2017
Merged

Add convenience container-runtime flag for kubeadm #2052

merged 6 commits into from
Oct 17, 2017

Commits on Oct 10, 2017

  1. [kubeadm] Pass features gates to components

    @r2d4
    r2d4 committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    dd50d76 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2017

  1. Extra arguments need to be quoted

    @r2d4
    r2d4 committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    967913b View commit details
    Browse the repository at this point in the history

  2. Add convenience container-runtime flag for kubeadm 

    To enable the cri-o runtime you may now just use

`minikube start --container-runtime=cri-o --bootstrapper=kubeadm`
or
`minikube start --container-runtiume=crio --bootstrapper=kubeadm`
or
`minikube start --extra-config=kubelet.container-runtime=remote
--extra-config=kubelet.container-runtime-endpoint=/var/run/crio.sock
--extra-config=image-service-endpoint=/var/run/crio.sock`
    @r2d4
    r2d4 committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    800be7e View commit details
    Browse the repository at this point in the history

  3. Add windows virtualbox kubeadm crio test

    @r2d4
    r2d4 committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    320b5cd View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2017

  1. Use path instead of filepath for cross platform

    @r2d4
    r2d4 committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    1a38ef7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Review feedback

    @r2d4
    r2d4 committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    37456d2 View commit details
    Browse the repository at this point in the history