Add convenience container-runtime flag for kubeadm #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
=========================================
+ Coverage 28.59% 28.9% +0.31%
=========================================
Files 80 81 +1
Lines 5243 5304 +61
=========================================
+ Hits 1499 1533 +34
- Misses 3551 3578 +27
Partials 193 193
Continue to review full report at Codecov.
|
To enable the cri-o runtime you may now just use `minikube start --container-runtime=cri-o --bootstrapper=kubeadm` or `minikube start --container-runtiume=crio --bootstrapper=kubeadm` or `minikube start --extra-config=kubelet.container-runtime=remote --extra-config=kubelet.container-runtime-endpoint=/var/run/crio.sock --extra-config=image-service-endpoint=/var/run/crio.sock`
dlorenc
reviewed
Oct 15, 2017
| @@ -262,17 +302,35 @@ sudo systemctl start kubelet | |||
| return nil | |||
| } | |||
|
|
|||
| func parseFeatureGates(featureGates string) (map[string]string, error) { | |||
There was a problem hiding this comment.
I don't see this used outside of tests.
| `)) | ||
|
|
||
| func installWants(containerRuntime string) string { |
There was a problem hiding this comment.
Could you do this directly in the template with an if statement?
dlorenc
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2037
To enable the cri-o runtime you may now just use
or
or