-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover "awsregion" parameter for registry-creds addon #1888
Conversation
It seems the "awsregion" parameter was removed in 8ba6f47 (kubernetes#1711) unexpectedly. It caused making incorrect awsecr-cred with unexpected aws region.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
I've just signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## master #1888 +/- ##
=======================================
Coverage 32.23% 32.23%
=======================================
Files 69 69
Lines 4104 4104
=======================================
Hits 1323 1323
Misses 2608 2608
Partials 173 173 Continue to review full report at Codecov.
|
I'm not too familar with this part of the code, but it looks like we want to just add back in aws-region, while keeping aws-account |
@r2d4 Yes, correct. |
Got it, thanks! |
It seems the "awsregion" parameter was removed in 8ba6f47 (#1711) unexpectedly.
It caused making incorrect awsecr-cred with unexpected aws region.
see also: #1757 (comment)