Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover "awsregion" parameter for registry-creds addon #1888

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

dragon3
Copy link
Contributor

@dragon3 dragon3 commented Aug 25, 2017

It seems the "awsregion" parameter was removed in 8ba6f47 (#1711) unexpectedly.
It caused making incorrect awsecr-cred with unexpected aws region.

see also: #1757 (comment)

It seems the "awsregion" parameter was removed in 8ba6f47 (kubernetes#1711) unexpectedly.
It caused making incorrect awsecr-cred with unexpected aws region.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dragon3
Copy link
Contributor Author

dragon3 commented Aug 25, 2017

I've just signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 25, 2017
@codecov-io
Copy link

Codecov Report

Merging #1888 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1888   +/-   ##
=======================================
  Coverage   32.23%   32.23%           
=======================================
  Files          69       69           
  Lines        4104     4104           
=======================================
  Hits         1323     1323           
  Misses       2608     2608           
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0d03f...6daef73. Read the comment docs.

@dragon3 dragon3 changed the title Recover "awsregion" parameter for registry-cred addon Recover "awsregion" parameter for registry-creds addon Aug 25, 2017
@r2d4
Copy link
Contributor

r2d4 commented Aug 25, 2017

I'm not too familar with this part of the code, but it looks like we want to just add back in aws-region, while keeping aws-account

@dragon3
Copy link
Contributor Author

dragon3 commented Aug 25, 2017

@r2d4 Yes, correct.
Before this pull request, there were duplicated aws-account definitions, and if there is no aws-region parameter, registry-creds addon doesn't work properly.

@r2d4 r2d4 merged commit 3c9603a into kubernetes:master Aug 26, 2017
@r2d4
Copy link
Contributor

r2d4 commented Aug 26, 2017

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants