Add additional config options for registry-creds addon / Bump version #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
=======================================
Coverage 35.95% 35.95%
=======================================
Files 51 51
Lines 3332 3332
=======================================
Hits 1198 1198
Misses 1954 1954
Partials 180 180Continue to review full report at Codecov.
|
|
@minikube-bot add to whitelist |
|
@minikube-bot OK to test |
r2d4
approved these changes
Jul 20, 2017
|
LGTM, merging |
dragon3
added a commit
to dragon3/minikube
that referenced
this pull request
Aug 25, 2017
It seems the "awsregion" parameter was removed in 8ba6f47 (kubernetes#1711) unexpectedly. It caused making incorrect awsecr-cred with unexpected aws region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a recent PR to registry-creds addon for AWS that allows you to assume an IAM role. This PR adds those config options to minikube as well as updates the version to include this change.