Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japanese translation (LINE 550-613) #13092

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Update Japanese translation (LINE 550-613) #13092

merged 2 commits into from
Dec 15, 2021

Conversation

yosshy
Copy link
Contributor

@yosshy yosshy commented Dec 5, 2021

/hold for japanese developer's review
/assign @t-inu
/cc @atoato88 @s-kawamura-w664

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yosshy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

atoato88
atoato88 reviewed Dec 6, 2021
View reviewed changes
translations/ja.json Outdated Show resolved Hide resolved
atoato88
atoato88 reviewed Dec 6, 2021
View reviewed changes
translations/ja.json Outdated Show resolved Hide resolved
@atoato88
Copy link
Contributor

atoato88 commented Dec 6, 2021

LGTM.
It's better for waiting response other reviewer if any.
So I response as "LGTM" not slash-lgtm message.

t-inu
t-inu reviewed Dec 6, 2021
View reviewed changes
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
translations/ja.json Outdated Show resolved Hide resolved
@atoato88
Copy link
Contributor

atoato88 commented Dec 9, 2021

Current PR has updated both of L614 and L615, is it OK? Doesn't thease conflict with other (maybe your) PRs?
That's because this PR's title says "(LINE 550-613)".

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2021
@yosshy
Copy link
Contributor Author

yosshy commented Dec 13, 2021

Current PR has updated both of L614 and L615, is it OK? Doesn't thease conflict with other (maybe your) PRs? That's because this PR's title says "(LINE 550-613)".

Lines sometimes shift because of commits of automatic updating the message catalog.

t-inu
t-inu reviewed Dec 14, 2021
View reviewed changes
translations/ja.json Outdated Show resolved Hide resolved
@yosshy @t-inu
Update translations/ja.json
0d45632 
Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@yosshy
Copy link
Contributor Author

yosshy commented Dec 14, 2021

@t-inu thank you for your review again.

@t-inu
Copy link
Member

t-inu commented Dec 14, 2021

/lgtm
It's OK as Japanese reveiw.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2021
@yosshy
Copy link
Contributor Author

yosshy commented Dec 14, 2021

/unhold
/assign @sharifelgamal

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2021
@spowelljr spowelljr merged commit 4375fc8 into kubernetes:master Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, t-inu, yosshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@yosshy
Copy link
Contributor Author

yosshy commented Dec 15, 2021

@spowelljr thank you for merging it.

@yosshy yosshy deleted the japanese-translation10 branch December 16, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-inu t-inu t-inu left review comments

@s-kawamura-w664 s-kawamura-w664 s-kawamura-w664 left review comments

@atoato88 atoato88 atoato88 left review comments

@spowelljr spowelljr spowelljr approved these changes

Assignees

@sharifelgamal sharifelgamal

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yosshy @k8s-ci-robot @minikube-bot @atoato88 @t-inu @spowelljr @s-kawamura-w664 @sharifelgamal