Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Upgrade Docker, from 20.10.6 to 20.10.8 #12122

Merged
merged 3 commits into from
Aug 7, 2021
Merged

ISO: Upgrade Docker, from 20.10.6 to 20.10.8 #12122

merged 3 commits into from
Aug 7, 2021

Conversation

afbjorklund
Copy link
Collaborator

https://docs.docker.com/engine/release-notes/#20108

  • runc v1.0.1

  • containerd v1.4.9

Squashed it together with 20.10.7, from PR #11593

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2021
@sharifelgamal
Copy link
Collaborator

ok-to-build-iso

@afbjorklund afbjorklund changed the title ISO: Upgrade Docker, from 20.10.7 to 20.10.8 ISO: Upgrade Docker, from 20.10.6 to 20.10.8 Aug 4, 2021
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 4, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 50.2s    | 48.2s               |
| enable ingress | 34.1s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 39.8s 32.3s 32.9s 34.3s 31.3s
Times for minikube (PR 12122) ingress: 30.8s 32.4s 32.8s 30.3s 32.3s

Times for minikube start: 50.1s 47.3s 55.6s 46.8s 51.4s
Times for minikube (PR 12122) start: 47.9s 47.7s 48.1s 46.6s 50.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.2s               |
| enable ingress | 32.0s    | 33.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 12122) ingress: 31.5s 32.0s 30.5s 35.0s 37.0s
Times for minikube ingress: 31.0s 26.5s 30.5s 35.5s 36.5s

Times for minikube start: 23.5s 22.5s 22.2s 22.9s 21.5s
Times for minikube (PR 12122) start: 21.9s 22.7s 23.1s 22.2s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 43.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.4s 43.9s 43.1s 43.9s 42.9s
Times for minikube (PR 12122) start: 42.7s 44.7s 44.2s 44.4s 43.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestFunctional/parallel/BuildImage (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 0.00 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/Stop (gopogh) 0.00 (chart)
KVM_Linux_crio TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 1.09 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 2.08 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 2.08 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 2.44 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/GCPAuth (gopogh) 3.12 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 3.12 (chart)
Docker_Linux_docker_arm64 TestFunctional/serial/ComponentHealth (gopogh) 3.37 (chart)
Docker_Linux_crio TestKubernetesUpgrade (gopogh) 6.06 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/LogsCmd (gopogh) 6.25 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/LogsFileCmd (gopogh) 6.25 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/BuildImage (gopogh) 7.14 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/Pause (gopogh) 8.08 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/Pause (gopogh) 8.51 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/FirstStart (gopogh) 14.08 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/SecondStart (gopogh) 14.49 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 19.72 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/DeployApp (gopogh) 33.33 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 36.11 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 38.03 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 44.05 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 46.94 (chart)
Docker_Linux_crio_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 47.96 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/custom-weave/Start (gopogh) 50.56 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/kindnet/Start (gopogh) 52.81 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@afbjorklund
Copy link
Collaborator Author

The test failures with the Docker driver (and KIC) are unrelated to this PR, which only changes the ISO

@medyagh
Copy link
Member

medyagh commented Aug 5, 2021

@afbjorklund sorry needs a rebase (since other ISO PR was merged now this one is not happy)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021
@afbjorklund
Upgrade Docker, from 20.10.6 to 20.10.7
cd08ce7 
    runc v1.0.0-rc95

    containerd v1.4.6
@afbjorklund
Upgrade Docker, from 20.10.7 to 20.10.8
7971e04 
    runc v1.0.1

    containerd v1.4.9
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2021
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 49.4s    | 48.7s               |
| enable ingress | 34.4s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 12122) start: 47.6s 49.6s 47.4s 48.9s 50.1s
Times for minikube start: 50.8s 49.2s 48.3s 52.0s 46.8s

Times for minikube ingress: 32.7s 32.3s 40.8s 32.2s 33.7s
Times for minikube (PR 12122) ingress: 32.3s 32.4s 31.3s 32.3s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.0s               |
| enable ingress | 30.2s    | 31.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 21.6s 22.1s 22.3s 22.1s
Times for minikube (PR 12122) start: 23.1s 21.7s 21.7s 22.1s 21.5s

Times for minikube (PR 12122) ingress: 31.5s 26.5s 31.5s 34.5s 31.5s
Times for minikube ingress: 36.5s 31.5s 26.5s 26.5s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 43.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 29.8s 43.7s 44.8s 44.0s 43.2s
Times for minikube (PR 12122) start: 42.7s 43.6s 42.9s 43.3s 43.5s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 48.7s    | 49.2s               |
| enable ingress | 32.0s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 12122) start: 47.7s 48.2s 51.9s 47.0s 51.1s
Times for minikube start: 47.9s 46.4s 51.2s 49.0s 49.0s

Times for minikube ingress: 31.9s 31.8s 30.8s 31.8s 33.7s
Times for minikube (PR 12122) ingress: 33.4s 32.7s 32.2s 30.8s 30.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.1s               |
| enable ingress | 33.2s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 12122) start: 22.7s 22.4s 22.5s 21.1s 22.0s
Times for minikube start: 22.1s 22.0s 21.5s 21.9s 22.0s

Times for minikube ingress: 31.0s 34.5s 34.5s 34.5s 31.5s
Times for minikube (PR 12122) ingress: 31.5s 30.5s 32.0s 35.0s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12122) |
+----------------+----------+---------------------+
| minikube start | 42.0s    | 44.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.6s 36.8s 43.6s 42.7s 43.4s
Times for minikube (PR 12122) start: 43.3s 43.1s 43.5s 43.2s 47.2s

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 6, 2021 •
edited
Loading

I added a bug about the failing test for KVM_Linux and KVM_Linux_containerd: #12145

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 1.01 (chart)
KVM_Linux_crio TestRunningBinaryUpgrade (gopogh) 1.92 (chart)
Hyperkit_macOS TestAddons/parallel/HelmTiller (gopogh) 2.04 (chart)
Docker_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 2.78 (chart)
Docker_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 2.80 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 2.80 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 2.86 (chart)
KVM_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 2.91 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 3.12 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 3.16 (chart)
Docker_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 4.21 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 7.41 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 7.48 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 8.41 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 8.41 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 8.51 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsCmd (gopogh) 9.35 (chart)
Docker_Linux_crio TestNetworkPlugins/group/auto/DNS (gopogh) 12.96 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 15.24 (chart)
Docker_Windows TestInsufficientStorage (gopogh) 16.67 (chart)
KVM_Linux TestGvisorAddon (gopogh) 19.05 (chart)
Docker_Windows TestAddons/parallel/HelmTiller (gopogh) 23.96 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 27.37 (chart)
Docker_Windows TestAddons/parallel/Olm (gopogh) 35.42 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 40.57 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_docker_arm64 TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/ValidateNameConflict (gopogh) 1.16 (chart)
Hyperkit_macOS TestAddons/parallel/HelmTiller (gopogh) 2.04 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/CSI (gopogh) 2.20 (chart)
Docker_Linux_docker_arm64 TestScheduledStopUnix (gopogh) 3.30 (chart)
Docker_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 3.67 (chart)
Docker_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 3.70 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 3.70 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 3.77 (chart)
KVM_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 3.85 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 4.17 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 4.40 (chart)
Docker_Linux_containerd TestAddons/parallel/CSI (gopogh) 4.63 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/RestartKeepsNodes (gopogh) 5.81 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 6.67 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 6.67 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 7.41 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 7.69 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 8.24 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 8.57 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/GCPAuth (gopogh) 8.57 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 9.20 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 9.26 (chart)
Docker_Linux_containerd_arm64 TestKubernetesUpgrade (gopogh) 9.52 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 10.10 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 11.43 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/AddNode (gopogh) 12.09 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/StartAfterStop (gopogh) 12.09 (chart)
Docker_Linux_crio TestNetworkPlugins/group/auto/DNS (gopogh) 12.84 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 16.67 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 543cca5 into kubernetes:master Aug 7, 2021
@afbjorklund afbjorklund mentioned this pull request Aug 14, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afbjorklund @sharifelgamal @minikube-bot @minikube-pr-bot @medyagh @k8s-ci-robot