Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestAddons/parallel/HelmTiller failing to pull the image #12145

Closed
afbjorklund opened this issue Aug 6, 2021 · 3 comments · Fixed by #12641
Closed

Fix TestAddons/parallel/HelmTiller failing to pull the image #12145

afbjorklund opened this issue Aug 6, 2021 · 3 comments · Fixed by #12641
Assignees
@duttaANI
Labels
area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 6, 2021 •
edited
Loading

deploy/addons/helm-tiller

TestAddons/parallel/HelmTiller

gcr.io/kubernetes-helm/tiller:v2.16.12

Error response from daemon: unauthorized: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication

Should update to the End-Of-Life image:

$ docker pull ghcr.io/helm/tiller:v2.17.0 
v2.17.0: Pulling from helm/tiller
Digest: sha256:4c43eb385032945cad047d2350e4945d913b90b3ab43ee61cecb32a495c6df0f
Status: Image is up to date for ghcr.io/helm/tiller:v2.17.0
ghcr.io/helm/tiller:v2.17.0

https://github.com/helm/helm/releases/tag/v2.17.0

Helm v2.17.0 is a feature release of Helm v2. The focus of this release is the End of Life for Helm v2 support and the deprecation of the stable and incubator Helm chart repositories. The chart repositories are moving to a new location that will serve as a long term archive.
@afbjorklund afbjorklund added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. area/addons and removed kind/bug Categorizes issue or PR as related to a bug. labels Aug 6, 2021
@afbjorklund afbjorklund mentioned this issue Aug 6, 2021
Merged
@afbjorklund afbjorklund changed the title The helm2 tiller addon is failing to pull the image Fix TestAddons/parallel/HelmTiller failing to pull the image Aug 6, 2021
@medyagh
Copy link
Member

medyagh commented Aug 7, 2021

Thanks for noting this

@sharifelgamal
Copy link
Collaborator

so we have updated our addons to pull ghcr.io/helm/tiller:v2.16.12 so that things don't totally fail, but i agree we should update the image to v2.17.0, which should be as easy as changing https://github.com/kubernetes/minikube/blob/master/pkg/minikube/assets/addons.go#L470 to be the correct image.

@sharifelgamal sharifelgamal added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 29, 2021
@duttaANI duttaANI mentioned this issue Oct 1, 2021
Merged
@duttaANI
Copy link
Contributor

duttaANI commented Oct 1, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duttaANI duttaANI

Labels
area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Helm Tiller image to v2.17.0 duttaANI/minikube
4 participants
@medyagh @afbjorklund @sharifelgamal @duttaANI