Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error output of minikube version --components command #12085

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Aug 1, 2021

The daemons might not be running, and it was duplicating some of the information.

Also sort the output and remove some of the line noise (especially crio is awful here)

Fixes #12083

Nothing much we can do, about the total lack of formatting of the --version commands. 😔


BEFORE

minikube version: v1.22.0
commit: a03fbcf166e6f74ef224d4a63be4277d017bb62e

runc:
runc version 1.0.0-rc95
commit: b9ee9c6314599f1b4a7f497e1f1f856fe433d3b7
spec: 1.0.2-dev
go: go1.13.15
libseccomp: 2.5.1

containerd:
containerd containerd.io 1.4.6 d71fcd7d8303cbf684402823e425e9dd2e99285d

podman:
Version:      3.2.2
API Version:  3.2.2
Go Version:   go1.15.2
Built:        Thu Jan  1 00:00:00 1970
OS/Arch:      linux/amd64

crictl:
Version:  0.1.0
RuntimeName:  cri-o
RuntimeVersion:  1.20.3
RuntimeApiVersion:  v1alpha1

docker:
error

crio:
Version:       1.20.3
GitCommit:     50065140109e8dc4b8fd6dc5d2b587e5cb7ed79d
GitTreeState:  clean
BuildDate:     2021-06-03T20:25:45Z
GoVersion:     go1.15.2
Compiler:      gc
Platform:      linux/amd64
Linkmode:      dynamic

buildctl:
buildctl github.com/moby/buildkit v0.8.2 9065b18ba4633c75862befca8188de4338d9f94a

ctr:
error

AFTER

minikube version: v1.22.0
commit: 6e571d830f76ccc87dd56cf893f50e2e8f8c6306

buildctl:
buildctl github.com/moby/buildkit v0.8.2 9065b18ba4633c75862befca8188de4338d9f94a

containerd:
containerd containerd.io 1.4.6 d71fcd7d8303cbf684402823e425e9dd2e99285d

crictl:
crictl version unknown

crio:
crio version 1.20.3

ctr:
ctr containerd.io 1.4.6

docker:
Docker version 20.10.7, build f0df350

dockerd:
Docker version 20.10.7, build b0f5bc3

podman:
podman version 3.2.2

runc:
runc version 1.0.0-rc95

Since the server daemon might not be running

This affects docker and containerd runtimes
Some commands, like crio and runc, dump extra line noise
after the --version even though they have a long version.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund
Copy link
Collaborator Author

Missing crun and buildkitd, but those should be simple one-liner afterwards.

@medyagh medyagh merged commit 54d16b7 into kubernetes:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube version --components docker error
4 participants