minikube version --components docker error

[spowelljr]

% minikube version --components
...

docker:
error

...

MacOS: 11.5.1
Docker: 20.10.7

[afbjorklund]

I get the same results on Ubuntu, at least when running with containerd runtime (rather expected?)

I0731 10:31:29.124307  378880 ssh_runner.go:149] Run: docker version --format={{.Client.Version}}
I0731 10:31:29.158173  378880 command_runner.go:124] > 20.10.7
I0731 10:31:29.160482  378880 command_runner.go:124] ! Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
W0731 10:31:29.160524  378880 version.go:68] error getting docker's version: docker version --format={{.Client.Version}}: Process exited with status 1

I suppose we could log the CLI version instead, like we do with ctr (vs containerd) for instance.

$ minikube ssh -- docker version --format='{{.Client.Version}}'
20.10.7
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
ssh: Process exited with status 1
$ minikube ssh -- docker --version
Docker version 20.10.7, build f0df350
$ minikube ssh -- dockerd --version
Docker version 20.10.7, build b0f5bc3

[spowelljr]

@afbjorklund Ah, you're right, forgot that instance was containerd, but I agree we should log something else instead of error.

[afbjorklund]

You get the same results from "ctr version", when running with CRI-O. I will make a PR to use --version instead of version.

ctr:
error

docker:
error

$ minikube ssh -- sudo ctr version
Client:
  Version:  1.4.6
  Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d
  Go version: go1.13.15

ctr: failed to dial "/run/containerd/containerd.sock": context deadline exceeded
ssh: Process exited with status 1

$ minikube ssh -- ctr --version
ctr containerd.io 1.4.6
$ minikube ssh -- containerd --version
containerd containerd.io 1.4.6 d71fcd7d8303cbf684402823e425e9dd2e99285d

Once we fix the bug of installing unused container runtimes, we will start to get a lot more "command not found" instead.