WIP: Fix the broken cgroups checks #11777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
ilya-zuyev
reviewed
Jun 28, 2021
| // HasCPUCFSPeriod checks whether it is possible to set cpu cfs period for cgroup. | ||
| func HasCPUCFSPeriod() bool { | ||
| cpuCfsPeriod := true | ||
| if runtime.GOOS == "linux" { |
There was a problem hiding this comment.
for non-Linux HasCPUCFSPeriod() always returns true. If it's by design, let's change the name.
"CFS" makes sense only in Linux context
|
Not really in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11609
Basically a bunch of duplicated checks from moby, which in turn gets them from libcontainer. Needs to be updated for cgroups v2.