The check for memory limits is currently broken for cgroups v1

[afbjorklund]

Currently it checks "" (empty string), if cgroup2 is false:

// HasMemoryCgroup checks whether it is possible to set memory limit for cgroup.
func HasMemoryCgroup() bool {
        memcg := true
        if runtime.GOOS == "linux" {
                var memory string
                if cgroup2, err := IsCgroup2UnifiedMode(); err == nil && cgroup2 {
                        memory = "/sys/fs/cgroup/memory/memsw.limit_in_bytes"
                }
                if _, err := os.Stat(memory); os.IsNotExist(err) {
                        klog.Warning("Your kernel does not support memory limit capabilities or the cgroup is not mounted.")
                        memcg = false
                }
        }
        return memcg
}

Since 7b0bf57

Most likely the code is also wrong for cgroups v2 as well ?

The end result is no memory limits, for the docker driver.

Seems to be the same issue as in #10935

[sharifelgamal]

Yeah this seems like a simple fix, let's do it ASAP.

[sharifelgamal]

@daehyeok could you look at this?

[afbjorklund]

Will let someone look at this, wasn't so simple it seems.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[sharifelgamal]

This remains an issue we'd like to fix.