Add faster profile list command with -l or --light option.

[daehyeok]

If option is true, Doens't try to get profiles from container and read
current status.

fix #10147

❯ minikube profile list -h
Lists all valid minikube profiles and detects all possible invalid profiles.

Options:
  -l, --light=false: If true, only display vaild profiles and do not check status.
  -o, --output='table': The output format. One of 'json', 'table'

Usage:
  minikube profile list [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).
❯ minikube profile list
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
|            Profile             | VM Driver | Runtime |      IP       | Port | Version | Status  | Nodes |
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
| minikube                       | docker    | docker  | 192.168.49.2  | 8443 | v1.20.0 | Stopped |     1 |
| multinode-20210127144027-24120 | docker    | docker  | 192.168.49.57 | 8443 | v1.20.2 | Stopped |     2 |
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
❯ minikube profile list -l
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
|            Profile             | VM Driver | Runtime |      IP       | Port | Version | Status  | Nodes |
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
| minikube                       | docker    | docker  | 192.168.49.2  | 8443 | v1.20.0 | Skipped |     1 |
| multinode-20210127144027-24120 | docker    | docker  | 192.168.49.57 | 8443 | v1.20.2 | Skipped |     2 |
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
❯ minikube profile list --light
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
|            Profile             | VM Driver | Runtime |      IP       | Port | Version | Status  | Nodes |
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|
| minikube                       | docker    | docker  | 192.168.49.2  | 8443 | v1.20.0 | Skipped |     1 |
| multinode-20210127144027-24120 | docker    | docker  | 192.168.49.57 | 8443 | v1.20.2 | Skipped |     2 |
|--------------------------------|-----------|---------|---------------|------|---------|---------|-------|

[k8s-ci-robot]

Hi @daehyeok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daehyeok
To complete the pull request process, please assign sharifelgamal after the PR has been reviewed.
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@daehyeok thank you for this PR I verified manually it is much faster !

medya@~/workspace/minikube (profile_list_light) $ time ./out/minikube profile list 
|----------|-----------|------------|--------------|------|---------|---------|-------|
| Profile  | VM Driver |  Runtime   |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|------------|--------------|------|---------|---------|-------|
| minikube | docker    | containerd | 192.168.49.2 | 8443 | v1.20.2 | Running |     1 |
| p1       | docker    | docker     | 192.168.59.2 | 8443 | v1.20.2 | Running |     1 |
|----------|-----------|------------|--------------|------|---------|---------|-------|

real    0m1.359s
user    0m0.784s
sys     0m0.391s
medya@~/workspace/minikube (profile_list_light) $ time ./out/minikube profile list --light
|----------|-----------|------------|--------------|------|---------|---------|-------|
| Profile  | VM Driver |  Runtime   |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|------------|--------------|------|---------|---------|-------|
| minikube | docker    | containerd | 192.168.49.2 | 8443 | v1.20.2 | Skipped |     1 |
| p1       | docker    | docker     | 192.168.59.2 | 8443 | v1.20.2 | Skipped |     1 |
|----------|-----------|------------|--------------|------|---------|---------|-------|

real    0m0.118s
user    0m0.057s

[medyagh]

@daehyeok thank you for this PR , please see comments

[daehyeok]

Resolved comment

=== RUN   TestFunctional/parallel/ProfileCmd/profile_list
    functional_test.go:785: (dbg) Run:  out/minikube profile list
    functional_test.go:785: (dbg) Done: out/minikube profile list: (9.835436564s)
    functional_test.go:790: Took "9.835598408s" to run "out/minikube profile list"
    functional_test.go:799: (dbg) Run:  out/minikube profile list -l
    functional_test.go:804: Took "345.226888ms" to run "out/minikube profile list -l"

[medyagh]

since -l is super fast
we can make the integraiton test to check for it be less than 3 seconds as well
so how about we add an integration test that if proflile list -l took more than 3 seconds it should fail
that profile list -l should not take long

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
Times for minikube: 67.6s 69.1s 67.2s
Average time for minikube: 68.0s

Times for Minikube (PR 10380): 69.5s 67.2s 69.1s
Average time for Minikube (PR 10380): 68.6s

Averages Time Per Log

+--------------------------------+----------+---------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 10380) |
+--------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian   | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)               |          |                     |
| * Using the kvm2 driver based  | 0.0s     | 0.0s                |
| on user configuration          |          |                     |
| * Starting control plane node  | 0.0s     | 0.0s                |
| minikube in cluster minikube   |          |                     |
| * Creating kvm2 VM (CPUs=2,    | 40.9s    | 41.8s               |
| Memory=3700MB, Disk=20000MB)   |          |                     |
| ...                            |          |                     |
| * Preparing Kubernetes v1.20.2 | 2.3s     | 9.5s                |
| on Docker 20.10.2 ...          |          |                     |
|   - Generating certificates    | 4.5s     | 2.3s                |
| and keys ...                   |          |                     |
|   - Booting up control plane   | 16.3s    | 11.3s               |
| ...                            |          |                     |
|   - Configuring RBAC rules ... | 1.5s     | 1.2s                |
| * Verifying Kubernetes         | 1.7s     | 1.6s                |
| components...                  |          |                     |
| * Enabled addons:              | 0.6s     |                     |
| default-storageclass,          |          |                     |
| storage-provisioner            |          |                     |
| * Done! kubectl is now         | 0.0s     | 0.0s                |
| configured to use "minikube"   |          |                     |
| cluster and "default"          |          |                     |
| namespace by default           |          |                     |
+--------------------------------+----------+---------------------+

docker Driver
Times for minikube: 26.4s 25.8s 24.9s
Average time for minikube: 25.7s

Times for Minikube (PR 10380): 25.2s 27.0s 25.4s
Average time for Minikube (PR 10380): 25.9s

Averages Time Per Log

+--------------------------------+----------+---------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 10380) |
+--------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian   | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)               |          |                     |
| * Using the docker driver      | 0.1s     | 0.1s                |
| based on user configuration    |          |                     |
| * Starting control plane node  | 0.1s     | 0.1s                |
| minikube in cluster minikube   |          |                     |
| * Creating docker container    | 9.9s     | 9.9s                |
| (CPUs=2, Memory=3700MB) ...    |          |                     |
| * Preparing Kubernetes v1.20.2 | 14.4s    | 14.6s               |
| on Docker 20.10.2 ...          |          |                     |
| * Verifying Kubernetes         | 0.9s     | 0.9s                |
| components...                  |          |                     |
| * Enabled addons:              | 0.1s     | 0.1s                |
| storage-provisioner,           |          |                     |
| default-storageclass           |          |                     |
| * Done! kubectl is now         | 0.0s     | 0.0s                |
| configured to use "minikube"   |          |                     |
| cluster and "default"          |          |                     |
| namespace by default           |          |                     |
+--------------------------------+----------+---------------------+