Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --light option to invoke profile list without checking status (for cheaper and faster) #10147

Closed
medyagh opened this issue Jan 15, 2021 · 3 comments · Fixed by #10380
Closed

add --light option to invoke profile list without checking status (for cheaper and faster) #10147

medyagh opened this issue Jan 15, 2021 · 3 comments · Fixed by #10380
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Jan 15, 2021 •
edited
Loading 

$ minikube profile list  
|----------|-----------|---------|--------------|------|---------|---------|-------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|---------|--------------|------|---------|---------|-------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.20.0 | Running |     1 |
|----------|-----------|---------|--------------|------|---------|---------|-------|

to this

$ minikube profile list --light
|----------|-----------|---------|--------------|------|---------|---------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version |  Nodes |
|----------|-----------|---------|--------------|------|---------|---------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.20.0 | 1 |
|----------|-----------|---------|--------------|------|---------|---------|
@medyagh
Copy link
Member Author

medyagh commented Jan 15, 2021

we could potentially also instead of not showing the status, we could show "skipped"

$ minikube profile list  
|----------|-----------|---------|--------------|------|---------|---------|-------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|---------|--------------|------|---------|---------|-------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.20.0 | Skipped |     1 |
|----------|-----------|---------|--------------|------|---------|---------|-------|

@medyagh
Copy link
Member Author

medyagh commented Jan 15, 2021

for @daehyeok

@medyagh medyagh added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 15, 2021
@medyagh medyagh changed the title add option to invoke profile list without checking status (for cheaper and faster) add --light option to invoke profile list without checking status (for cheaper and faster) Jan 15, 2021
@medyagh medyagh changed the title add --light option to invoke profile list without checking status (for cheaper and faster) add --light option to invoke profile list without checking status (for cheaper and faster) Jan 15, 2021
@daehyeok
Copy link
Contributor

I will reuse my implementation after #10119 is merged.

@daehyeok daehyeok mentioned this issue Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add faster profile list command with -l or --light option. daehyeok/minikube
2 participants
@daehyeok @medyagh