Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Make Debian/RedHat package revisions settable #10004

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Makefile: Make Debian/RedHat package revisions settable #10004

merged 3 commits into from
Jan 25, 2021

Conversation

tstromberg
Copy link
Contributor

Used to push a package revision to help resolve #9995

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2020
@bl-ue bl-ue mentioned this pull request Dec 18, 2020
Closed
afbjorklund
afbjorklund requested changes Dec 19, 2020
View reviewed changes
Makefile Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Jan 6, 2021

@tstromberg please take a look at the comment.
PTAL

@medyagh medyagh mentioned this pull request Jan 20, 2021
Merged
@tstromberg tstromberg closed this Jan 20, 2021
@mgabeler-lee-6rs mgabeler-lee-6rs mentioned this pull request Jan 22, 2021
Closed
@tstromberg tstromberg reopened this Jan 22, 2021
@tstromberg
Copy link
Contributor Author

Both makefile rules now behave the same:

⋊> ~/s/minikube on deb_revision ⨯ make rpm_version                                                                                                                                                 1.16.0-0
⋊> ~/s/minikube on deb_revision ⨯ make deb_version                                                                                                                                                 1.16.0-0

afbjorklund
afbjorklund requested changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more line

But it was already changed

Makefile Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg merged commit 72598ee into kubernetes:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube_1.16.0-0_amd64.deb: package architecture (arm64) does not match system (amd64)
4 participants
@tstromberg @medyagh @k8s-ci-robot @afbjorklund