-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube_1.17.0-0_amd64.deb: package architecture (arm64) does not match system (amd64) #10224
Comments
@mgabeler-lee-6rs thank you very much for the quick issue you opened ! we totally screwed u ! and missed to merge the PRs |
Thanks for the quick followup :)
No need to feel too bad, I just noticed this because I have some scripts to pull new minikube releases into my workflow when I get the new release announcement from GH, and they tripped on this. My actual workflow continues happily using the prior release :) |
Any updates? We should definitely do a post-mortem for this event -- I should have done so the first time around. Assigning to @medyagh as he's on duty this week, though I understand @ilya-zuyev was also looking into this. |
@ilya-zuyev has removed the errant files from the release and will be posting new ones. |
Uploaded correct versions
|
for ARM Ubuntu:
|
our Makefile creates deb files using template
|
Normally, this field is increased each time that you update the package (for the same upstream software version): https://www.debian.org/doc/debian-policy/ch-controlfields.html#version Since we don't have any "real" system packages, but just a vendor package, we always kept this revision as
Then when we had to issue a rebuild, for the same version, we bumped it to If the minikube package would have been in the Debian distribution proper, it would have a more "normal" revision. |
@ilya-zuyev : unfortunately, it doesn't seem to work:
It was supposed to be built on an older platform (16.04) This was |
the "latest" from https://storage.googleapis.com/minikube/releases/latest/minikube_latest_amd64.deb is still the arm one |
a specific version see kubernetes/minikube#10224 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
a specific version see kubernetes/minikube#10224 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
a specific version see kubernetes/minikube#10224 using 1.16 instead of 1.17 as even pointing to updated .deb is nto working due to another problem: kubernetes/minikube#10224 (comment) Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Removed the bad .deb files from GCS that I was aware of.
|
@priyawadhwa is working on publishing updated debian release packages, containing the correct minikube amd64 binary. The package revision will be 2 (minikube_1.17.0-2_amd64.deb) |
Following #9995 (comment), I ran the following the manually upload correct binaries: Build:
Propagate:
Then uploaded manually to GitHub releases:
|
I've also removed minikube_1.17.0-0_amd64.deb and minikube_1.17.0-1_amd64.deb from the github release. The first was republished with changed checksums (against Debian policy), the second can't be installed on older distro's due to being linked against too new of a glibc |
Confirmed that the new packages install cleanly. Will leave this open for the next hour in case folks find additional issues, and then close. |
@mgabeler-lee-6rs do u mind verifying on your end if the issue is fixed now ? |
No new reports, so I'm going to close this issue. Please comment with /reopen if you see anything. |
@medyagh amd64 fix is good on my end. I do notice that the minikube_1.17.0-0_arm64.deb was removed from GitHub without replacement Edit: yes, I see that the |
A minor note: the rebuilt The same seems to be true of the |
Are you mentioning the versions reported by If the latter, this is intentional. The minikube binary installed by the Debian package is identical (same checksum) to the one we distributed for other platforms. The only thing we regenerated was the Debian packag, to contain the correct binary (ARM vs x86-64). The final version field used (2) is the Debian package revision: https://www.debian.org/doc/debian-policy/ch-controlfields.html#version |
The former -- the version info in the A quick check identifies the issue here: https://github.com/kubernetes/minikube/blob/master/Makefile#L478 That should be |
a specific version see kubernetes/minikube#10224 using 1.16 instead of 1.17 as even pointing to updated .deb is nto working due to another problem: kubernetes/minikube#10224 (comment) Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Steps to reproduce the issue:
This is #9995 again, because no fix was merged for it
#10004 was closed without any changes being merged it looks like, and #9998 is approved but not merged.
The broken binary from #9995 got addressed by @tstromberg doing some manual build & upload operations, seems 1.17.0 needs this again, unless #9998 can be merged and a 1.17.1 release sent out to replace it?
The text was updated successfully, but these errors were encountered: