SSH tunnels left open after sending SIGINT to minikube tunnel

[m-lima]

Steps to reproduce the issue:
Minikube running with docker driver on macOS Catalina

1. minikube tunnel
2. On another terminal: kill -INT <PID_OF_THE_PREVIOUS_COMMAND>
3. ps aux | grep minikube

Full output of failed command:
The ps command will show multiple ssh tunnels still open, outliving the parent process.

Details
In pkg/minikube/tunnel/kic/ssh_tunnel.go the interrupt signal is caught and it stops the LoadBalancerEmulator. However, it assumes that the interrupt will also propagate to the children ssh tunnels, which are running in a goroutine inside startConnections.
The interrupt, however, kills the goroutine and the blocking call which waits for the child process to finish. This leaves the ssh tunnels dangling.
On the other hand, if CTRL + C is sent on the same terminal as minikube tunnel and the clean-up routine included killing all ssh tunnels, the OS would error with "process already finished".

Related issues
#8511
#3647

[sharifelgamal]

Thanks for finding this and opening an issue. We should definitely fix this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[vishjain]

/assign

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten