Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ssh tunnels during exit. #11745

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Clean up ssh tunnels during exit. #11745

merged 2 commits into from
Aug 13, 2021

Conversation

vishjain
Copy link
Contributor

@vishjain vishjain commented Jun 22, 2021 •
edited
Loading

fixes #10752

Before PR:
PID TTY TIME CMD
1417 ttys000 0:00.14 /bin/bash --rcfile /Applications/GoLand.app/Contents/plugins/terminal/jediterm-bash.in -i
1696 ttys001 0:00.07 login -pf vishal
1698 ttys001 0:00.12 -bash
7548 ttys001 0:00.25 minikube tunnel
7565 ttys001 0:00.25 minikube tunnel

After PR (Deleting is successful with no stray tunnels) :
PID TTY TIME CMD
1417 ttys000 0:00.14 /bin/bash --rcfile /Applications/GoLand.app/Contents/plugins/terminal/jediterm-bash.in -i
1696 ttys001 0:00.07 login -pf vishal
1698 ttys001 0:00.12 -bash

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vishjain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

medyagh
medyagh requested changes Jun 22, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could u plz post before/after this PR in the PR Description ?

@vishjain
Copy link
Contributor Author

could u plz post before/after this PR in the PR Description ?

Done.

@vishjain vishjain requested a review from medyagh June 23, 2021 00:14
@vishjain
Copy link
Contributor Author

vishjain commented Jul 5, 2021

@medyagh Can you take a glance at this, Thanks!

@sharifelgamal
Copy link
Collaborator

@vishjain This looks good, could you just address the one comment above, then we can go ahead and run the full test suite.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishjain
To complete the pull request process, please assign prezha after the PR has been reviewed.
You can assign the PR to them by writing /assign @prezha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vishjain vishjain requested a review from ilya-zuyev July 25, 2021 21:46
@vishjain
Copy link
Contributor Author

@vishjain This looks good, could you just address the one comment above, then we can go ahead and run the full test suite.

I've made the necessary changes here.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11745) |
+----------------+----------+---------------------+
| minikube start | 48.3s    | 48.0s               |
| enable ingress | 34.9s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube start: 52.8s 46.5s 47.2s 48.1s 46.7s
Times for minikube (PR 11745) start: 46.9s 49.1s 48.4s 47.4s 48.2s

Times for minikube ingress: 46.3s 31.7s 31.8s 31.8s 32.8s
Times for minikube (PR 11745) ingress: 32.2s 31.8s 32.2s 32.3s 32.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11745) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 22.0s               |
| enable ingress | 34.4s    | 34.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 21.1s 22.4s 21.1s 21.7s
Times for minikube (PR 11745) start: 21.9s 21.9s 22.7s 21.8s 22.0s

Times for minikube (PR 11745) ingress: 35.5s 37.0s 32.0s 31.5s 35.5s
Times for minikube ingress: 32.5s 36.5s 35.5s 31.5s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11745) |
+----------------+----------+---------------------+
| minikube start | 40.9s    | 43.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.8s 43.7s 43.7s 42.7s 43.6s
Times for minikube (PR 11745) start: 43.3s 43.0s 42.7s 44.1s 44.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestNetworkPlugins/group/bridge/Start (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 2.11 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 2.11 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 4.21 (chart)
Docker_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 7.35 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 13.68 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 22.11 (chart)
Docker_Linux_crio TestStartStop/group/no-preload/serial/Stop (gopogh) 24.74 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 26.32 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 26.32 (chart)
Docker_Windows TestAddons/parallel/Olm (gopogh) 36.47 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 41.67 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 42.11 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 50.53 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 51.32 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 52.33 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 52.33 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 60.53 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 63.16 (chart)
Docker_Windows TestAddons/parallel/GCPAuth (gopogh) 63.53 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 73.68 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 75.00 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 80.26 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 81.58 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/bridge/Start (gopogh) 81.91 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 85.71 (chart)
Docker_Linux_crio TestMultiNode/serial/PingHostFrom2Pods (gopogh) 87.63 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 96.05 (chart)
Docker_Linux_crio_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 96.88 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 98.94 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit d7c3ade into kubernetes:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@medyagh medyagh Awaiting requested review from medyagh

@ilya-zuyev ilya-zuyev Awaiting requested review from ilya-zuyev

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH tunnels left open after sending SIGINT to minikube tunnel
8 participants
@vishjain @k8s-ci-robot @minikube-bot @sharifelgamal @spowelljr @minikube-pr-bot @medyagh @ilya-zuyev