Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force bootstrapper to localkube for minikube #426

Closed
wants to merge 1 commit into from
Closed

force bootstrapper to localkube for minikube #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ PROMETHEUS_VERSION=2.0.0
mkdir -p $KUBE_STATE_METRICS_LOG_DIR

# setup a Kubernetes cluster
curl -sLo minikube https://storage.googleapis.com/minikube/releases/v0.25.2/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
curl -sLo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
Copy link
Member

@brancz brancz Jul 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to still explicitly bump minikube, there have been numerous occasions where the latest releases were broken to a point where it was just not usable at all. Generally I prefer pinned rather than floating versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed for now since kube-state-metrics do not need any new feature that latest minikube supports. Let's first pin at v0.25.2 and seem whether Travis CI ubuntu image will support systemd alongside.


minikube version

Expand All @@ -40,7 +40,7 @@ mkdir $HOME/.kube || true
touch $HOME/.kube/config

export KUBECONFIG=$HOME/.kube/config
sudo minikube start --vm-driver=none --kubernetes-version=$KUBERNETES_VERSION --logtostderr
sudo minikube start --vm-driver=none --bootstrapper=localkube --kubernetes-version=$KUBERNETES_VERSION --logtostderr

minikube update-context

Expand Down