force bootstrapper to localkube for minikube #426
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
lgtm on green nonetheless as the kubeadm bootstrapper is now the default, we should try to find out how to eventually use something based on that, as I imagine the localkube bootstrapper will eventually be deprecated and removed. |
|
@brancz We can wait the minikube maintainers to give more suggestion on this before merging this. If they chose a patch release to mitigate this problem, we should do nothing. :) |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
| @@ -26,7 +26,7 @@ PROMETHEUS_VERSION=2.0.0 | |||
| mkdir -p $KUBE_STATE_METRICS_LOG_DIR | |||
|
|
|||
| # setup a Kubernetes cluster | |||
| curl -sLo minikube https://storage.googleapis.com/minikube/releases/v0.25.2/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/ | |||
| curl -sLo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/ | |||
There was a problem hiding this comment.
I'd prefer to still explicitly bump minikube, there have been numerous occasions where the latest releases were broken to a point where it was just not usable at all. Generally I prefer pinned rather than floating versions.
There was a problem hiding this comment.
Agreed for now since kube-state-metrics do not need any new feature that latest minikube supports. Let's first pin at v0.25.2 and seem whether Travis CI ubuntu image will support systemd alongside.
Force minikube use localkube as the bootstrapper instead of kubeadm. For more info: kubernetes/minikube#2704