Skip to content

Enforce topologySpreadConstraints for CoreDNS #17472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2025
Merged

Enforce topologySpreadConstraints for CoreDNS #17472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce3c7b4
Update AMI for e2e templates
hakman Jul 4, 2025
6820d75
coredns: Enforce topologySpreadConstraints
hakman Jul 4, 2025
2091de1
coredns: Update to v1.11.4
hakman Jul 4, 2025
8ae77d6
hack/update-expected.sh
hakman Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/e2e/templates/apiserver-dns-none.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: t3.medium
maxSize: 4
minSize: 4
Expand All @@ -82,7 +82,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: c5.large
maxSize: 1
minSize: 1
Expand All @@ -100,7 +100,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: c5.large
maxSize: 1
minSize: 1
Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/templates/apiserver.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ metadata:
labels:
kops.k8s.io/cluster: {{.clusterName}}
spec:
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
instanceMetadata:
httpPutResponseHopLimit: 1
httpTokens: required
Expand All @@ -84,7 +84,7 @@ metadata:
labels:
kops.k8s.io/cluster: {{.clusterName}}
spec:
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
instanceMetadata:
httpPutResponseHopLimit: 1
httpTokens: required
Expand All @@ -104,7 +104,7 @@ metadata:
labels:
kops.k8s.io/cluster: {{.clusterName}}
spec:
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
instanceMetadata:
httpPutResponseHopLimit: 1
httpTokens: required
Expand All @@ -124,7 +124,7 @@ metadata:
labels:
kops.k8s.io/cluster: {{.clusterName}}
spec:
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
instanceMetadata:
httpPutResponseHopLimit: 1
httpTokens: required
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/templates/many-addons.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ metadata:
kops.k8s.io/cluster: {{$.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: t3.medium
maxSize: 2
minSize: 2
Expand All @@ -113,7 +113,7 @@ metadata:
kops.k8s.io/cluster: {{$.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: c5.large
maxSize: 1
minSize: 1
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/templates/simple.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: t3.medium
maxSize: 4
minSize: 4
Expand All @@ -76,7 +76,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: c5.large
maxSize: 1
minSize: 1
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/templates/staticcpumanagerpolicy.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: t3.medium
maxSize: 4
minSize: 4
Expand All @@ -86,7 +86,7 @@ metadata:
kops.k8s.io/cluster: {{.clusterName}}
spec:
associatePublicIp: true
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20240927
image: 099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250610
machineType: c5.large
maxSize: 1
minSize: 1
Expand Down
2 changes: 1 addition & 1 deletion ...ditionalobjects/data/aws_s3_object_additionalobjects.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
8 changes: 4 additions & 4 deletions ...aws_s3_object_additionalobjects.example.com-addons-coredns.addons.k8s.io-k8s-1.12_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
- args:
- -conf
- /etc/coredns/Corefile
image: registry.k8s.io/coredns/coredns:v1.11.3
image: registry.k8s.io/coredns/coredns:v1.11.4
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 5
Expand Down Expand Up @@ -194,13 +194,13 @@ spec:
k8s-app: kube-dns
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
- labelSelector:
matchLabels:
k8s-app: kube-dns
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
volumes:
- configMap:
name: coredns
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}}
- --logtostderr=true
- --v=2
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.9.0
name: autoscaler
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion ...te_cluster/apiservernodes/data/aws_s3_object_minimal.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
8 changes: 4 additions & 4 deletions ...odes/data/aws_s3_object_minimal.example.com-addons-coredns.addons.k8s.io-k8s-1.12_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
- args:
- -conf
- /etc/coredns/Corefile
image: registry.k8s.io/coredns/coredns:v1.11.3
image: registry.k8s.io/coredns/coredns:v1.11.4
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 5
Expand Down Expand Up @@ -194,13 +194,13 @@ spec:
k8s-app: kube-dns
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
- labelSelector:
matchLabels:
k8s-app: kube-dns
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
volumes:
- configMap:
name: coredns
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}}
- --logtostderr=true
- --v=2
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.9.0
name: autoscaler
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion ...cluster/aws-lb-controller/data/aws_s3_object_minimal.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
8 changes: 4 additions & 4 deletions ...ller/data/aws_s3_object_minimal.example.com-addons-coredns.addons.k8s.io-k8s-1.12_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
- args:
- -conf
- /etc/coredns/Corefile
image: registry.k8s.io/coredns/coredns:v1.11.3
image: registry.k8s.io/coredns/coredns:v1.11.4
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 5
Expand Down Expand Up @@ -194,13 +194,13 @@ spec:
k8s-app: kube-dns
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
- labelSelector:
matchLabels:
k8s-app: kube-dns
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
volumes:
- configMap:
name: coredns
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}}
- --logtostderr=true
- --v=2
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.9.0
name: autoscaler
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion ...itional_user-data/data/aws_s3_object_bastionuserdata.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
8 changes: 4 additions & 4 deletions ...a/aws_s3_object_bastionuserdata.example.com-addons-coredns.addons.k8s.io-k8s-1.12_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
- args:
- -conf
- /etc/coredns/Corefile
image: registry.k8s.io/coredns/coredns:v1.11.3
image: registry.k8s.io/coredns/coredns:v1.11.4
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 5
Expand Down Expand Up @@ -194,13 +194,13 @@ spec:
k8s-app: kube-dns
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
- labelSelector:
matchLabels:
k8s-app: kube-dns
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
volumes:
- configMap:
name: coredns
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}}
- --logtostderr=true
- --v=2
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.9.0
name: autoscaler
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion ...stom/data/aws_s3_object_cas-priority-expander-custom.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
8 changes: 4 additions & 4 deletions ...ct_cas-priority-expander-custom.example.com-addons-coredns.addons.k8s.io-k8s-1.12_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
- args:
- -conf
- /etc/coredns/Corefile
image: registry.k8s.io/coredns/coredns:v1.11.3
image: registry.k8s.io/coredns/coredns:v1.11.4
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 5
Expand Down Expand Up @@ -194,13 +194,13 @@ spec:
k8s-app: kube-dns
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
- labelSelector:
matchLabels:
k8s-app: kube-dns
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
volumes:
- configMap:
name: coredns
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}}
- --logtostderr=true
- --v=2
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.9.0
name: autoscaler
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion ...ty-expander/data/aws_s3_object_cas-priority-expander.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
8 changes: 4 additions & 4 deletions ...s3_object_cas-priority-expander.example.com-addons-coredns.addons.k8s.io-k8s-1.12_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
- args:
- -conf
- /etc/coredns/Corefile
image: registry.k8s.io/coredns/coredns:v1.11.3
image: registry.k8s.io/coredns/coredns:v1.11.4
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 5
Expand Down Expand Up @@ -194,13 +194,13 @@ spec:
k8s-app: kube-dns
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
- labelSelector:
matchLabels:
k8s-app: kube-dns
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
whenUnsatisfiable: DoNotSchedule
volumes:
- configMap:
name: coredns
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}}
- --logtostderr=true
- --v=2
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9
image: registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.9.0
name: autoscaler
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion ...on/update_cluster/complex/data/aws_s3_object_complex.example.com-addons-bootstrap_content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
version: 9.99.0
- id: k8s-1.12
manifest: coredns.addons.k8s.io/k8s-1.12.yaml
manifestHash: 591e3b40d00949575616698ce1c9230db8cb00bdab4f8a0d5ef14080a1d7a93c
manifestHash: 5cf27d74240a028d347903ee2a81d068e221660f19a9c71b4e8438b8f3c8de81
name: coredns.addons.k8s.io
selector:
k8s-addon: coredns.addons.k8s.io
Expand Down
Loading
Loading