Skip to content

Enforce topologySpreadConstraints for CoreDNS #17472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2025
Merged

Enforce topologySpreadConstraints for CoreDNS #17472

merged 4 commits into from
Jul 4, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 4, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/addons labels Jul 4, 2025
@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

/cc @thiagoluiznunes

@k8s-ci-robot
Copy link
Contributor

@hakman: GitHub didn't allow me to request PR reviews from the following users: thiagoluiznunes.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @thiagoluiznunes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ameukam
Copy link
Member

ameukam commented Jul 4, 2025

/test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

/test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

@ameukam I think the problem should be solved with this kubernetes/test-infra#35089.

This was referenced Jul 4, 2025
Closed
Closed
@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

/test pull-kops-e2e-aws-upgrade-k132-ko132-to-klatest-kolatest-many-addons

@hakman hakman mentioned this pull request Jul 4, 2025
Closed
@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

/hold to investigate the bare-metal test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@hakman hakman force-pushed the coredns-topologyspreadconstraints branch from 6cc2288 to 763da5c Compare July 4, 2025 13:43
@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

/hold to investigate the bare-metal test

Metal provider doesn't have the topology.kubernetes.io/zone label.

@kubernetes kubernetes deleted a comment from k8s-ci-robot Jul 4, 2025
@hakman hakman force-pushed the coredns-topologyspreadconstraints branch from afc7c8f to b60cd13 Compare July 4, 2025 14:28
@hakman hakman force-pushed the coredns-topologyspreadconstraints branch from b60cd13 to b0444c3 Compare July 4, 2025 15:51
@hakman hakman force-pushed the coredns-topologyspreadconstraints branch from b0444c3 to 8ae77d6 Compare July 4, 2025 16:48
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2025
@hakman
Copy link
Member Author

hakman commented Jul 4, 2025

Thanks @rifelpet! 🙂
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0338039 into kubernetes:master Jul 4, 2025
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jul 4, 2025
@hakman hakman deleted the coredns-topologyspreadconstraints branch July 5, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @ameukam @rifelpet