-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed secret file locations to match results from docker-compose when using file-based secrets #1478
Fixed secret file locations to match results from docker-compose when using file-based secrets #1478
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @campos-ddc! |
7b68a72
to
b6e8d35
Compare
b6e8d35
to
455fc2b
Compare
… using file-based secrets
455fc2b
to
acf24e9
Compare
Tested with a local k8s cluster and files seem to be in the right place when using the new flag (replicating docker-compose behavior). |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Any chance that this will ever get reviewed? I'm really trying here, and would hate to give up and live with a fork forever. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: campos-ddc, kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Thank you, @campos-ddc for contributing to kompose. |
Fixes #1280
--
Still need to do some tests to make sure everything works, hopefully CI will also point out any issues.