Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for file based secret #1159

Merged
merged 9 commits into from
Dec 1, 2019
Merged

Add support for file based secret #1159

merged 9 commits into from
Dec 1, 2019

Conversation

jvitor83
Copy link
Contributor

@jvitor83 jvitor83 commented Aug 2, 2019 •
edited
Loading

Related to issue #296 and PR #1007

Support for:

  • Short syntax
  • Long syntax
    • Absolute path

Based on work from @hangyan.
As asked by @cdrage at #1007 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign janetkuo
You can assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot requested review from hangyan and kadel August 2, 2019 04:24
@alanjds
Copy link
Contributor

alanjds commented Aug 6, 2019

/assign @janetkuo

@alanjds
Copy link
Contributor

alanjds commented Aug 6, 2019

cc: @henriquegibin
See also: #296 (comment)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2019
@jvitor83
Copy link
Contributor Author

@hangyan @janetkuo @kadel
Any news about this PR?

@hangyan
Copy link
Contributor

hangyan commented Dec 1, 2019

my apologize, will review this from now

@hangyan
Copy link
Contributor

hangyan commented Dec 1, 2019

test_stdin failed, this is a long exist issue, can be ignored for now.

@hangyan hangyan merged commit 30736a3 into kubernetes:master Dec 1, 2019
@ChanderG
Copy link
Contributor

ChanderG commented Dec 2, 2019 •
edited
Loading

@hangyan The new secrets related test also seems to have failed: https://travis-ci.org/kubernetes/kompose/jobs/619127981#L1121.

Those tests fail deterministically on a local copy of master as well.

@hangyan
Copy link
Contributor

hangyan commented Dec 2, 2019

That's wired, i'm sure i only see a stdin test failed for this PR.. @ChanderG would you mind to fix this tests and i will review this ASAP? This will help us a lot

@ChanderG
Copy link
Contributor

ChanderG commented Dec 2, 2019

@hangyan , have opened a PR #1198.

@ChanderG
Copy link
Contributor

ChanderG commented Dec 4, 2019 •
edited
Loading

@hangyan , just to confirm stdin_test always fails?
But from my understanding so far, though it fails, the overall tests should pass / have the CI return a green tick.

@campos-ddc campos-ddc mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangyan hangyan hangyan approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@janetkuo janetkuo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jvitor83 @k8s-ci-robot @alanjds @fejta-bot @hangyan @ChanderG @janetkuo