Fix IngressClass logic for newer releases #7341

rikatz · 2021-07-12T01:24:31Z

Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com

What this PR does / why we need it:

Fix IngressClass logics for releases > v1.19

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #7277

How Has This Been Tested?

Tests are still ongoing, a lot of e2e tests needs to be written

TODO

Fix / add all unit tests / e2e tests
Document how to adapt the new deployment
- If user wants to create ingress without ingressclass, the watchwithoutingressclass should be used
- Create a default ingress-nginx ingress class with .spec.controller pointing to k8s.io/ingress-nginx
- Document how annotations will behave and conflict mgmt between annotations and the ingressClassName

Need community feedback of migrations between v0.47 and the new one.

rikatz · 2021-07-12T01:27:27Z

/assign @tao12345666333 @cpanato

Many eyes is better here, I still will write the e2e tests and also run a lot of tests

tao12345666333

I will review in more detail later.

cmd/nginx/main.go

rikatz · 2021-07-12T01:46:34Z

@tao12345666333 no rush to review this yet, it's a WIP and I will continue tomorrow :D

rikatz · 2021-07-14T00:04:05Z

unit tests are working fine.

Next step is to add proper e2e tests and the required migration documentation

cpanato · 2021-07-16T07:11:31Z

saw this unknown flag: --controller-class in the tests that fail

Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>

test/e2e/run-chart-test.sh

cpanato

this is a huge effort @rikatz thank you for doing this!

besides @tao12345666333 comments it LGTM with my limited knowledge

longwuyuan · 2021-07-26T12:47:56Z

Will ensure docs are crystal clear on this. Thanks, -- ; Long 26 Jul 2021, 17:34 by ***@***.***:

…

@rikatz> commented on this pull request. In > charts/ingress-nginx/values.yaml <#7341 (comment)>> : > ingressClassResource:- enabled: false+ name: nginx+ enabled: true default: false Will answer just this and let the others to later: The idea of default here being false is because when you set it to true, it will assume every new Ingress resource created in the cluster must have / use that ingress class. This is bad, if you have other controllers running in the cluster. Imagine the same situation with StorageClass, where you have a default storageclass, and then a Helm chart adds another storageclass saying "hey, this is the new default". Now, two things may happen: Cluster will refuse to create new ingress resources if you have two default classes (I guess this is the default behavior) or, if you don't have any default class, but a bunch of other controllers, this helm chart will take over. IMO this should be an opt-in, and we need to document really well in the migration guide. For the majority of users, it's fine and also great to have a default ingressclass if they run only one ingress controller :) I'm worried about the corner cases — You are receiving this because you are subscribed to this thread. Reply to this email directly, > view it on GitHub <#7341 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWUSDVOHVWBDO6UAD3DTZVFMNANCNFSM5AF3LU2Q>> .

strongjz · 2021-07-26T13:44:19Z

internal/ingress/controller/controller_test.go

@@ -188,7 +189,7 @@ func TestCheckIngress(t *testing.T) {
 			},
 		},
 	}
-
+	/* TODO: Right now we have stopped to check IngressClass in Admission


is this because of the older k8s version diffs and issues with kind etc.?

Sort of...validating IngressClass in Admission is hard, as we don't know what ingress class that annotation represents.

https://github.com/kubernetes/ingress-nginx/pull/7341/files/94f3838205e048f62f5d3fa8b60bb2caa0af6b45#diff-4198ec010671801881244a8052177f31bcbc682c99fbd7391bceb136025c0568R225-R229

internal/ingress/controller/store/ingress_class.go

rikatz · 2021-07-26T23:31:58Z

Fixed some reviews :D

tao12345666333

Leave a few comments, overall it's great!

/lgtm
/hold

tao12345666333 · 2021-07-26T23:49:38Z

cmd/nginx/main.go

 			}
-			klog.ErrorS(err, "Searching IngressClass", "class", class.IngressClass)


Should we deal with other errors? Just log the error.

Ricgt now, nope. I think that in this case, now we are not searching for a specific Ingress (was Get before, now is List) as the controllers needs to list and get all the ingressclasses.

So if controller does not have permission for this, it should not work at all IMO

tao12345666333 · 2021-07-26T23:54:19Z

internal/ingress/controller/controller.go

-
-	if !class.IsValid(ing) {
-		klog.Warningf("ignoring ingress %v in %v based on annotation %v", ing.Name, ing.ObjectMeta.Namespace, class.IngressKey)
+	/* TODO: Should we / how can we check for ingress class?


Maybe we don't need check for ingress class. Its inspection result is meaningless to us.

yeah, I agree. I've left this code as a legacy, as this is a TODO we can remove in this PR or maybe in a future. I guess removing now is fine :)

And removed :)

I'm afraid the checking will have to be done again somehow. Not doing it seems to lead to all kinds of issues, see #7546

tao12345666333 · 2021-07-27T00:19:39Z

internal/ingress/controller/store/store.go

@@ -296,6 +300,9 @@ func New(
 	store.informers.Ingress = infFactory.Networking().V1().Ingresses().Informer()
 	store.listers.Ingress.Store = store.informers.Ingress.GetStore()

+	store.informers.IngressClass = infFactory.Networking().V1().IngressClasses().Informer()
+	store.listers.IngressClass.Store = cache.NewStore(cache.MetaNamespaceKeyFunc)


Is cache.NewStore used here instead of informer's local cache because of thread safety?

Nope. I've used this as a New Store, otherwise following the other logics it would fetch everything from the store/informer regardless of the filtering or not.

But can say I've had no idea what I was doing, so I might be wrong here :)

tao12345666333

/lgtm

k8s-ci-robot · 2021-07-28T11:27:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rikatz · 2021-07-28T21:58:08Z

/hold cancel
Thank you all for the reviews! Now let's set fire on the dumpster :D

* Fix IngressClass logic for newer releases Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Change e2e tests for the new IngressClass presence * Fix chart and admission tests Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix helm chart test Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix reviews * Remove ingressclass code from admission

* Drop v1beta1 from ingress nginx (#7156) * Drop v1beta1 from ingress nginx Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix intorstr logic in controller Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * fixing admission Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * more intorstr fixing * correct template rendering Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix e2e tests for v1 api Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix gofmt errors * This is finally working...almost there... Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Re-add removed validation of AdmissionReview * Prepare for v1.0.0-alpha.1 release Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Update changelog and matrix table for v1.0.0-alpha.1 (#7274) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * add docs for syslog feature (#7219) * Fix link to e2e-tests.md in developer-guide (#7201) * Use ENV expansion for namespace in args (#7146) Update the DaemonSet namespace references to use the `POD_NAMESPACE` environment variable in the same way that the Deployment does. * chart: using Helm builtin capabilities check (#7190) Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> * Update proper default value for HTTP2MaxConcurrentStreams in Docs (#6944) It should be 128 as documented in https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/config/config.go#L780 * Fix MaxWorkerOpenFiles calculation on high cores nodes (#7107) * Fix MaxWorkerOpenFiles calculation on high cores nodes * Add e2e test for rlimit_nofile * Fix doc for max-worker-open-files * ingress/tcp: add additional error logging on failed (#7208) * Add file containing stable release (#7313) * Handle named (non-numeric) ports correctly (#7311) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Updated v1beta1 to v1 as its deprecated (#7308) * remove mercurial from build (#7031) * Retry to download maxmind DB if it fails (#7242) * Retry to download maxmind DB if it fails. Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Add retries count arg, move retry logic into DownloadGeoLite2DB function Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Reorder parameters in DownloadGeoLite2DB Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Remove hardcoded value Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Release v1.0.0-alpha.1 * Add changelog for v1.0.0-alpha.2 * controller: ignore non-service backends (#7332) * controller: ignore non-service backends Signed-off-by: Carlos Panato <ctadeu@gmail.com> * update per feedback Signed-off-by: Carlos Panato <ctadeu@gmail.com> * fix: allow scope/tcp/udp configmap namespace to altered (#7161) * Lower webhook timeout for digital ocean (#7319) * Lower webhook timeout for digital ocean * Set Digital Ocean value controller.admissionWebhooks.timeoutSeconds to 29 * update OWNERS and aliases files (#7365) (#7366) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Downgrade Lua modules for s390x (#7355) Downgrade Lua modules to last known working version. * Fix IngressClass logic for newer releases (#7341) * Fix IngressClass logic for newer releases Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Change e2e tests for the new IngressClass presence * Fix chart and admission tests Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix helm chart test Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix reviews * Remove ingressclass code from admission * update tag to v1.0.0-beta.1 * update readme and changelog for v1.0.0-beta.1 * Release v1.0.0-beta.1 - helm and manifests (#7422) * Change the order of annotation just to trigger a new helm release (#7425) * [cherry-pick] Add dev-v1 branch into helm releaser (#7428) * Add dev-v1 branch into helm releaser (#7424) * chore: add link for artifacthub.io/prerelease annotations Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com> * k8s job ci pipeline for dev-v1 br v1.22.0 (#7453) * k8s job ci pipeline for dev-v1 br v1.22.0 Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * k8s job ci pipeline for dev-v1 br v1.21.2 Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * remove v1.21.1 version Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * Add controller.watchIngressWithoutClass config option (#7459) Signed-off-by: Akshit Grover <akshit.grover2016@gmail.com> * Release new helm chart with certgen fixed (#7478) * Update go version, modules and remove ioutil * Release new helm chart with certgen fixed * changed appversion, chartversion, TAG, image (#7490) * Fix CI conflict * Fix CI conflict * Fix build.sh from rebase process * Fix controller_test post rebase Co-authored-by: Tianhao Guo <rggth09@gmail.com> Co-authored-by: Ray <61553+rctay@users.noreply.github.com> Co-authored-by: Bill Cassidy <cassid4@gmail.com> Co-authored-by: Jintao Zhang <tao12345666333@163.com> Co-authored-by: Sathish Ramani <rsathishx87@gmail.com> Co-authored-by: Mansur Marvanov <nanorobocop@gmail.com> Co-authored-by: Matt1360 <568198+Matt1360@users.noreply.github.com> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Co-authored-by: Kundan Kumar <kundan.kumar@india.nec.com> Co-authored-by: Tom Hayward <thayward@infoblox.com> Co-authored-by: Sergey Shakuto <sshakuto@infoblox.com> Co-authored-by: Tore <tore.lonoy@gmail.com> Co-authored-by: Bouke Versteegh <info@boukeversteegh.nl> Co-authored-by: Shahid <shahid@us.ibm.com> Co-authored-by: James Strong <strong.james.e@gmail.com> Co-authored-by: Long Wu Yuan <longwuyuan@gmail.com> Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: Neha Lohia <nehapithadiya444@gmail.com> Co-authored-by: Akshit Grover <akshit.grover2016@gmail.com>

* Drop v1beta1 from ingress nginx (kubernetes#7156) * Drop v1beta1 from ingress nginx Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix intorstr logic in controller Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * fixing admission Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * more intorstr fixing * correct template rendering Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix e2e tests for v1 api Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix gofmt errors * This is finally working...almost there... Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Re-add removed validation of AdmissionReview * Prepare for v1.0.0-alpha.1 release Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Update changelog and matrix table for v1.0.0-alpha.1 (kubernetes#7274) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * add docs for syslog feature (kubernetes#7219) * Fix link to e2e-tests.md in developer-guide (kubernetes#7201) * Use ENV expansion for namespace in args (kubernetes#7146) Update the DaemonSet namespace references to use the `POD_NAMESPACE` environment variable in the same way that the Deployment does. * chart: using Helm builtin capabilities check (kubernetes#7190) Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> * Update proper default value for HTTP2MaxConcurrentStreams in Docs (kubernetes#6944) It should be 128 as documented in https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/config/config.go#L780 * Fix MaxWorkerOpenFiles calculation on high cores nodes (kubernetes#7107) * Fix MaxWorkerOpenFiles calculation on high cores nodes * Add e2e test for rlimit_nofile * Fix doc for max-worker-open-files * ingress/tcp: add additional error logging on failed (kubernetes#7208) * Add file containing stable release (kubernetes#7313) * Handle named (non-numeric) ports correctly (kubernetes#7311) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Updated v1beta1 to v1 as its deprecated (kubernetes#7308) * remove mercurial from build (kubernetes#7031) * Retry to download maxmind DB if it fails (kubernetes#7242) * Retry to download maxmind DB if it fails. Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Add retries count arg, move retry logic into DownloadGeoLite2DB function Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Reorder parameters in DownloadGeoLite2DB Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Remove hardcoded value Signed-off-by: Sergey Shakuto <sshakuto@infoblox.com> * Release v1.0.0-alpha.1 * Add changelog for v1.0.0-alpha.2 * controller: ignore non-service backends (kubernetes#7332) * controller: ignore non-service backends Signed-off-by: Carlos Panato <ctadeu@gmail.com> * update per feedback Signed-off-by: Carlos Panato <ctadeu@gmail.com> * fix: allow scope/tcp/udp configmap namespace to altered (kubernetes#7161) * Lower webhook timeout for digital ocean (kubernetes#7319) * Lower webhook timeout for digital ocean * Set Digital Ocean value controller.admissionWebhooks.timeoutSeconds to 29 * update OWNERS and aliases files (kubernetes#7365) (kubernetes#7366) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Downgrade Lua modules for s390x (kubernetes#7355) Downgrade Lua modules to last known working version. * Fix IngressClass logic for newer releases (kubernetes#7341) * Fix IngressClass logic for newer releases Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Change e2e tests for the new IngressClass presence * Fix chart and admission tests Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix helm chart test Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix reviews * Remove ingressclass code from admission * update tag to v1.0.0-beta.1 * update readme and changelog for v1.0.0-beta.1 * Release v1.0.0-beta.1 - helm and manifests (kubernetes#7422) * Change the order of annotation just to trigger a new helm release (kubernetes#7425) * [cherry-pick] Add dev-v1 branch into helm releaser (kubernetes#7428) * Add dev-v1 branch into helm releaser (kubernetes#7424) * chore: add link for artifacthub.io/prerelease annotations Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com> * k8s job ci pipeline for dev-v1 br v1.22.0 (kubernetes#7453) * k8s job ci pipeline for dev-v1 br v1.22.0 Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * k8s job ci pipeline for dev-v1 br v1.21.2 Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * remove v1.21.1 version Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com> * Add controller.watchIngressWithoutClass config option (kubernetes#7459) Signed-off-by: Akshit Grover <akshit.grover2016@gmail.com> * Release new helm chart with certgen fixed (kubernetes#7478) * Update go version, modules and remove ioutil * Release new helm chart with certgen fixed * changed appversion, chartversion, TAG, image (kubernetes#7490) * Fix CI conflict * Fix CI conflict * Fix build.sh from rebase process * Fix controller_test post rebase Co-authored-by: Tianhao Guo <rggth09@gmail.com> Co-authored-by: Ray <61553+rctay@users.noreply.github.com> Co-authored-by: Bill Cassidy <cassid4@gmail.com> Co-authored-by: Jintao Zhang <tao12345666333@163.com> Co-authored-by: Sathish Ramani <rsathishx87@gmail.com> Co-authored-by: Mansur Marvanov <nanorobocop@gmail.com> Co-authored-by: Matt1360 <568198+Matt1360@users.noreply.github.com> Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com> Co-authored-by: Kundan Kumar <kundan.kumar@india.nec.com> Co-authored-by: Tom Hayward <thayward@infoblox.com> Co-authored-by: Sergey Shakuto <sshakuto@infoblox.com> Co-authored-by: Tore <tore.lonoy@gmail.com> Co-authored-by: Bouke Versteegh <info@boukeversteegh.nl> Co-authored-by: Shahid <shahid@us.ibm.com> Co-authored-by: James Strong <strong.james.e@gmail.com> Co-authored-by: Long Wu Yuan <longwuyuan@gmail.com> Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: Neha Lohia <nehapithadiya444@gmail.com> Co-authored-by: Akshit Grover <akshit.grover2016@gmail.com>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2021

k8s-ci-robot requested review from cmluciano and strongjz July 12, 2021 01:24

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2021

rikatz changed the title ~~Fix IngressClass logic for newer releases~~ [WIP] Fix IngressClass logic for newer releases Jul 12, 2021

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2021

k8s-ci-robot assigned cpanato and tao12345666333 Jul 12, 2021

rikatz force-pushed the fix-ingress-class branch 2 times, most recently from 17f8ff6 to 91af365 Compare July 12, 2021 01:35

tao12345666333 reviewed Jul 12, 2021

View reviewed changes

cmd/nginx/main.go Outdated Show resolved Hide resolved

rikatz force-pushed the fix-ingress-class branch from 91af365 to dfbcb4a Compare July 12, 2021 01:47

rikatz changed the base branch from master to release-v1 July 13, 2021 19:14

rikatz force-pushed the fix-ingress-class branch from cb9ca48 to 30b4d83 Compare July 13, 2021 23:57

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2021

rikatz added 2 commits July 18, 2021 19:16

Fix IngressClass logic for newer releases

83b4e24

Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>

Change e2e tests for the new IngressClass presence

4d4dea8

rikatz force-pushed the fix-ingress-class branch from 75027b5 to 05fbbac Compare July 18, 2021 22:18

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2021

rikatz force-pushed the fix-ingress-class branch 2 times, most recently from e1de170 to c393c0f Compare July 25, 2021 19:07

cpanato reviewed Jul 26, 2021

View reviewed changes

test/e2e/run-chart-test.sh Outdated Show resolved Hide resolved

cpanato reviewed Jul 26, 2021

View reviewed changes

strongjz reviewed Jul 26, 2021

View reviewed changes

internal/ingress/controller/store/ingress_class.go Outdated Show resolved Hide resolved

Fix reviews

f5c4dc2

tao12345666333 reviewed Jul 27, 2021

View reviewed changes

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 27, 2021

rikatz changed the title ~~[WIP] Fix IngressClass logic for newer releases~~ Fix IngressClass logic for newer releases Jul 27, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2021

Remove ingressclass code from admission

0302284

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021

longwuyuan mentioned this pull request Jul 28, 2021

docs for migration to apiVersion networking.k8s.io v1 #7397

Closed

tao12345666333 approved these changes Jul 28, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021

tao12345666333 mentioned this pull request Jul 28, 2021

Things to do before the v1 version is released #7398

Closed

15 tasks

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021

k8s-ci-robot merged commit cef147a into kubernetes:dev-v1 Jul 28, 2021

rikatz mentioned this pull request Jul 29, 2021

Ignore ingress definitions for other ingressclasses #7277

Closed

mkreidenweis-schulmngr mentioned this pull request Nov 3, 2021

validating webhook should ignore ingresses with a different ingressclass #7546

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix IngressClass logic for newer releases #7341

Fix IngressClass logic for newer releases #7341

rikatz commented Jul 12, 2021

rikatz commented Jul 12, 2021

tao12345666333 left a comment

rikatz commented Jul 12, 2021

rikatz commented Jul 14, 2021

cpanato commented Jul 16, 2021

cpanato left a comment

longwuyuan commented Jul 26, 2021 via email

strongjz Jul 26, 2021

rikatz Jul 26, 2021

rikatz commented Jul 26, 2021

tao12345666333 left a comment

tao12345666333 Jul 26, 2021

rikatz Jul 27, 2021

tao12345666333 Jul 26, 2021

rikatz Jul 27, 2021

rikatz Jul 27, 2021

mkreidenweis-schulmngr Oct 7, 2021

tao12345666333 Jul 27, 2021

rikatz Jul 27, 2021

tao12345666333 left a comment

k8s-ci-robot commented Jul 28, 2021

rikatz commented Jul 28, 2021

		}
		klog.ErrorS(err, "Searching IngressClass", "class", class.IngressClass)

Fix IngressClass logic for newer releases #7341

Fix IngressClass logic for newer releases #7341

Conversation

rikatz commented Jul 12, 2021

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

TODO

rikatz commented Jul 12, 2021

tao12345666333 left a comment

Choose a reason for hiding this comment

rikatz commented Jul 12, 2021

rikatz commented Jul 14, 2021

cpanato commented Jul 16, 2021

cpanato left a comment

Choose a reason for hiding this comment

longwuyuan commented Jul 26, 2021 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rikatz commented Jul 26, 2021

tao12345666333 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tao12345666333 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 28, 2021

rikatz commented Jul 28, 2021