-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs for migration to apiVersion networking.k8s.io v1 #7397
Comments
@longwuyuan: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-kind bug |
@longwuyuan: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind documentation |
/assign |
Use the advise below ;TODO: Fix helm chart tests If you are migrating from v0.X to v1.0, and you have only one ingress deployment in your environment, you can use the --watch-without-ingress-class flag (explain how to enable it in helm chart and/or deployment) In charts/ingress-nginx/values.yaml:
The idea of default here being false is because when you set it to true, it will assume every new Ingress resource created in the cluster must have / use that ingress class. This is bad, if you have other controllers running in the cluster. Imagine the same situation with StorageClass, where you have a default storageclass, and then a Helm chart adds another storageclass saying "hey, this is the new default". Now, two things may happen: Cluster will refuse to create new ingress resources if you have two default classes (I guess this is the default behavior) or, if you don't have any default class, but a bunch of other controllers, this helm chart will take over. IMO this should be an opt-in, and we need to document really well in the migration guide. For the majority of users, it's fine and also great to have a default ingressclass if they run only one ingress controller :) I'm worried about the corner cases |
PR merged so closing #7524 |
NGINX Ingress controller version:
all builds once k8s v1.22 is released
Kubernetes version (use
kubectl version
):v1.22 and above
Environment:
all supported environs
uname -a
):What happened:
As per #7341, we need docs for the migration to apiVersion networking.k8s.io/v1
What you expected to happen:
Required docs for the migration to apiVersion networking.k8s.io/v1 becomes available
How to reproduce it:
Currently the docs are not present
Anything else we need to know:
Discussion is in #7341
/area docs
The text was updated successfully, but these errors were encountered: