-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentracing operation name settings #5931
Add opentracing operation name settings #5931
Conversation
…e config settings With these settings custom span names can be used for the server span and location span Signed-off-by: Jorrit Salverda <jsalverda@travix.com>
…hub.com/JorritSalverda/ingress-nginx into add-opentracing-operation-name-settings
Welcome @bvandewalle! |
Hi @bvandewalle. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JorritSalverda In case you are still following this, it's based on your PR. Thanks for the initial work. |
/ok-to-test |
… to load at least one tracer to enable opentracing Work on PR comments Add tests for template builder Signed-off-by: Bernard Van De Walle <bernard.vandewalle@getcruise.com>
734b8a6
to
f353720
Compare
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, bvandewalle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bvandewalle thanks! |
What this PR does / why we need it:
Based on stale PR #4118
In order to set custom span names for server and location span use the following config items in the configmap:
Which issue/s this PR fixes
fixes #5829
fixes #4116
How Has This Been Tested?
Original PR had some E2E tests. Modified them to make them load a tracer (Zipkin in this case, this is required for nginx to not crash)
Checklist: