Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span name with Opentracing: Use the whole host, path and request #5829

Closed
bvandewalle opened this issue Jun 30, 2020 · 3 comments · Fixed by #5931
Closed

Span name with Opentracing: Use the whole host, path and request #5829

bvandewalle opened this issue Jun 30, 2020 · 3 comments · Fixed by #5931
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bvandewalle
Copy link
Contributor

I'm using nginx-ingress integration with opentracing and Datadog and it works fairly well.

One issue I have is that the span name seems to only be the path of the request.
As my nginx-ingress is configured with a lot of ingresses (with a lot of different hostnames ), it makes it difficult to know which host was called exactly without looking in the attributes.

What does the community think about having the span name formatted as HOST-PATH - METHOD ?

@bvandewalle bvandewalle added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2020
@bvandewalle
Copy link
Contributor Author

I found an old issue and PR related to this:
#4116
#4118

@aledbf
Copy link
Member

aledbf commented Jun 30, 2020

@bvandewalle if you take #4118, squashed and with passing e2e test that PR LGTM

@bvandewalle
Copy link
Contributor Author

Thanks @aledbf , will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants