Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vsphere csi migration test plan #3366

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Update vsphere csi migration test plan #3366

merged 1 commit into from
Jun 14, 2022

Conversation

divyenpatel
Copy link
Member

  • One-line PR description:
  • Other comments:

cc: @xing-yang

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 8, 2022
@xing-yang
Copy link
Contributor

/assign @gnufied @jingxu97

@divyenpatel divyenpatel force-pushed the update-1491-csi-migration-vsphere branch from 6c4cac7 to 2af888e Compare June 13, 2022 23:19
@divyenpatel
Copy link
Member Author

@xing-yang I have addressed your review comments

@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 13, 2022
@divyenpatel divyenpatel force-pushed the update-1491-csi-migration-vsphere branch from 2af888e to 1208981 Compare June 14, 2022 00:10
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit e67787f into kubernetes:master Jun 14, 2022
gnufied
gnufied reviewed Jun 14, 2022
View reviewed changes
keps/sig-storage/1491-csi-migration-vsphere/README.md
- No Integration tests required for this feature

### e2e tests
- Existing e2e tests developed for in-tree vSphere volume plugin executed - https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/vsphere
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CSI migration we also want to ensure that tests inside - https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/testsuites are passing before and after migration, using intree PVs. Can you please update this section? It is pretty much a requirement for all CSI migration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied addressed your review comment in this PR - #3398

@xing-yang xing-yang mentioned this pull request Jun 24, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@xing-yang xing-yang

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@divyenpatel @xing-yang @k8s-ci-robot @gnufied @jingxu97