Skip to content

Commit

Permalink
Update vsphere csi migration test plan
Browse files Browse the repository at this point in the history
  • Loading branch information
divyenpatel committed Jun 8, 2022
1 parent 8e7bf49 commit 6c4cac7
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 3 deletions.
31 changes: 30 additions & 1 deletion keps/sig-storage/1491-csi-migration-vsphere/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
<!-- toc -->
- [Summary](#summary)
- [New Feature Gates](#new-feature-gates)
- [Design Details](#design-details)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
- [Integration tests](#integration-tests)
- [e2e tests](#e2e-tests)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Implementation History](#implementation-history)
<!-- /toc -->
Expand Down Expand Up @@ -35,6 +40,27 @@ used as as described in its parent KEP. For all other contents, please refer to
on kubelet and treat vSphere CSI migration as already complete. And directly redirect traffic to CSI
driver for all vsphere volume related operations.

## Design Details
[X] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.
### Prerequisite testing updates
Additional tests added in the [vSphere CSI Driver repository](https://github.com/kubernetes-sigs/vsphere-csi-driver) to ensure vSphere CSI Migration is production ready.
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_create_delete.go
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_attach_detach.go
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_full_sync.go
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_syncer.go

### Unit tests
Unit tests for vSphere CSI Migration is added in the csi-translation-lib repository
- https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/vsphere_volume_test.go (85.1% coverage)

### Integration tests
- No Integration tests required for this feature

### e2e tests
- Existing e2e tests developed for in-tree vSphere volume plugin should pass - https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/vsphere


## Production Readiness Review Questionnaire

Expand All @@ -55,4 +81,7 @@ Major milestones for vSphere in-tree plugin CSI migration:
- vSphere CSI migration to Beta, off by default

- 1.24
- vSphere CSI migration to Beta, on by default
- vSphere CSI migration to Beta, off by default

- 1.25
- vSphere CSI migration to Stable
5 changes: 3 additions & 2 deletions keps/sig-storage/1491-csi-migration-vsphere/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ approvers:
- "@msau42"
editor: "@Jiawei0227"
creation-date: 2022-01-11
last-updated: 2022-01-11
last-updated: 2022-08-11
disable-supported: true
status: implementable
see-also:
Expand All @@ -27,12 +27,13 @@ stage: beta
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.24"
latest-milestone: "v1.25"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.18"
beta: "v1.19"
stable: "v1.25"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit 6c4cac7

Please sign in to comment.