Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3094: update NodeInclusionPolicyInPodTopologySpread details #3261

Merged
merged 2 commits into from
May 9, 2022
Merged

KEP-3094: update NodeInclusionPolicyInPodTopologySpread details #3261

merged 2 commits into from
May 9, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Apr 3, 2022 •
edited
Loading

Signed-off-by: kerthcet kerthcet@gmail.com

  • One-line PR description: Some design details changed and the feature is delayed until v1.25
  • Other comments: None

@kerthcet
update NodeInclusionPolicyInPodTopologySpread details
10fac72 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and Huang-Wei April 3, 2022 04:32
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Apr 3, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Apr 3, 2022

/sig scheduling
cc @Huang-Wei @alculquicondor

alculquicondor
alculquicondor reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md Outdated
}
```

There are two policies now regarding to nodeAffinity and nodeTaint:
We will define two NodeInclusionPolicy by default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We will define two NodeInclusionPolicy by default:
We will define two NodeInclusionPolicy:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@kikisdeliveryservice kikisdeliveryservice changed the title update NodeInclusionPolicyInPodTopologySpread details KEP-3094: update NodeInclusionPolicyInPodTopologySpread details Apr 5, 2022
@kerthcet
address the comments
2a68916 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet
Copy link
Member Author

kerthcet commented May 9, 2022

Need another lgtm before merging. @alculquicondor

@alculquicondor
Copy link
Member

/approve

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit edf5578 into kubernetes:master May 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 9, 2022
@kerthcet kerthcet deleted the feature/update-nodeInclusionPolicy branch May 9, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@kerthcet @alculquicondor @k8s-ci-robot