Create PULL_REQUEST_TEMPLATE.md #2554
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Pull Request Description | ||
| - KEP-< ISSUE NUMBER >: < KEP NAME > | ||
|
There was a problem hiding this comment. Could we also add a note here to link the k/enhancements issue instead of typing out the number? I think having the link would be a lot useful in the description :) There was a problem hiding this comment. I'd rather we just add a line following this one with : Issue link: |
||
| - One-line PR description: <!-- short description of work done in PR e.g. updating milestone, adding new KEP, adding test requirements… --> | ||
|
|
||
| _Please use the following format when naming your PR: **< Issue Number >:< Issue Description >** (e.g. KEP-000: adding beta graduation criteria)_ | ||
|
There was a problem hiding this comment. I'm not sure if we want to make this visible or make it a comment. what do you think @kikisdeliveryservice? There was a problem hiding this comment. I think make it a comment |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think heading level 1 might be too big? I think it might be better with like level 3 or 4?