Create PULL_REQUEST_TEMPLATE.md #2554
Conversation
Adding initial Pull Request Template to k/enhancements root
kendallroden
added
the
area/enhancements
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kendallroden The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| @@ -0,0 +1,5 @@ | |||
| # Pull Request Description | |||
There was a problem hiding this comment.
I think heading level 1 might be too big? I think it might be better with like level 3 or 4?
| @@ -0,0 +1,5 @@ | |||
| # Pull Request Description | |||
| - KEP-< ISSUE NUMBER >: < KEP NAME > | |||
There was a problem hiding this comment.
Could we also add a note here to link the k/enhancements issue instead of typing out the number? I think having the link would be a lot useful in the description :)
There was a problem hiding this comment.
I'd rather we just add a line following this one with :
Issue link:
| - KEP-< ISSUE NUMBER >: < KEP NAME > | ||
| - One-line PR description: <!-- short description of work done in PR e.g. updating milestone, adding new KEP, adding test requirements… --> | ||
|
|
||
| _Please use the following format when naming your PR: **< Issue Number >:< Issue Description >** (e.g. KEP-000: adding beta graduation criteria)_ |
There was a problem hiding this comment.
I'm not sure if we want to make this visible or make it a comment. what do you think @kikisdeliveryservice?
There was a problem hiding this comment.
I think make it a comment
|
Hey @kendallroden I think we can merge this in as soon as some of the comments are addressed :) |
|
@kendallroden -- are you still working on this? :) |
|
Closing this in favor of #2760. /close |
|
@palnabarun: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ref. #2518
Adding initial Pull Request Template to k/enhancements root
/cc @annajung @kikisdeliveryservice
/area enhancements
/assign @kikisdeliveryservice @annajung