Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packeges in devDependencies #6690

Merged
merged 17 commits into from
Jan 24, 2022

Conversation

shu-mutou
Copy link
Contributor

This PR updates dependencies for development that do not have breakable changes.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #6690 (2762b9e) into master (0326fb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6690   +/-   ##
=======================================
  Coverage   41.89%   41.89%           
=======================================
  Files          44       44           
  Lines        1234     1234           
  Branches      178      178           
=======================================
  Hits          517      517           
  Misses        678      678           
  Partials       39       39           

@floreks
Copy link
Member

floreks commented Jan 14, 2022

We should not constantly be doing this manually. We do have a bot that should keep our dependencies up-to-date. The only time when we should intervene is:

  • bulk update of related dependencies (i.e. angular)
  • breaking change update where bot created a PR but it fails or requires manual changes in the codebase
  • removal of unused dependencies

If the bot is not creating PRs then we should fix the bot configuration.

@shu-mutou
Copy link
Contributor Author

I found that dependabot is stopping to post PR for dashboard, because it does not support nodejs 16 and npm 8. 😞
So until following PR merged on dependabot, we need to update manually.
dependabot/dependabot-core#4531

@floreks
Copy link
Member

floreks commented Jan 14, 2022

Are you aware of how exactly is the bot checking which npm version is being used on the repo? We do not have an explicit version in the package.json anymore. I see that there is something in the lock file, but potentially we could change it to 7.X and this should allow bot to work maybe?

      "engines": {
        "node": ">=16.13.0 <17",
        "npm": ">=8.1.0 <9"
      }

v8 should be mostly backward compatible so maybe it would work.

@shu-mutou
Copy link
Contributor Author

bot doesn't support lockfile v3 actually.

@shu-mutou
Copy link
Contributor Author

we can find errors of dependabot in following page:
https://github.com/kubernetes/dashboard/network/updates/258146930

@floreks
Copy link
Member

floreks commented Jan 14, 2022

So it indeed takes the engine from our package.json. Maybe we could enable npm v7, for now, to allow the bot to work.

@shu-mutou
Copy link
Contributor Author

I will try to change engine in package.json in the other PR.
But dependabot have stopped already several weeks, I want to update dashboard's dependency once right now.

@floreks
Copy link
Member

floreks commented Jan 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6af2ce6 into kubernetes:master Jan 24, 2022
@shu-mutou shu-mutou deleted the dependencies branch January 25, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants