-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm packeges in devDependencies #6690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6690 +/- ##
=======================================
Coverage 41.89% 41.89%
=======================================
Files 44 44
Lines 1234 1234
Branches 178 178
=======================================
Hits 517 517
Misses 678 678
Partials 39 39 |
We should not constantly be doing this manually. We do have a bot that should keep our dependencies up-to-date. The only time when we should intervene is:
If the bot is not creating PRs then we should fix the bot configuration. |
I found that dependabot is stopping to post PR for dashboard, because it does not support nodejs 16 and npm 8. 😞 |
Are you aware of how exactly is the bot checking which npm version is being used on the repo? We do not have an explicit version in the "engines": {
"node": ">=16.13.0 <17",
"npm": ">=8.1.0 <9"
} v8 should be mostly backward compatible so maybe it would work. |
bot doesn't support lockfile v3 actually. |
we can find errors of dependabot in following page: |
So it indeed takes the |
I will try to change |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates dependencies for development that do not have breakable changes.